-
Notifications
You must be signed in to change notification settings - Fork 376
feat(clerk-js,clerk-react): Support Base authentication #6556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jacekradko
wants to merge
11
commits into
main
Choose a base branch
from
feat/support-base-wallet
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
95c1add
feat: support base wallet
jacekradko 681dcf7
changeset
jacekradko b1231e3
add missing dep and fix types
jacekradko 4e5193a
Merge branch 'main' into feat/support-base-wallet
jacekradko eccdecb
base_account -> base_wallet
jacekradko b350e56
Merge branch 'main' into feat/support-base-wallet
jacekradko 9c2c5b6
wip
jacekradko 5e05b7a
wip
jacekradko df00e95
wip
jacekradko dd94966
PR feedback
jacekradko e5be17f
Merge branch 'main' into feat/support-base-wallet
jacekradko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
'@clerk/clerk-js': minor | ||
'@clerk/shared': minor | ||
'@clerk/clerk-react': minor | ||
'@clerk/types': minor | ||
--- | ||
|
||
Adding support for Base Account |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -58,6 +58,10 @@ export async function getOKXWalletIdentifier(): Promise<string> { | |
return await getWeb3Identifier({ provider: 'okx_wallet' }); | ||
} | ||
|
||
export async function getBaseWalletIdentifier(): Promise<string> { | ||
return await getWeb3Identifier({ provider: 'base_wallet' }); | ||
} | ||
|
||
type GenerateSignatureParams = { | ||
identifier: string; | ||
nonce: string; | ||
|
@@ -75,6 +79,10 @@ export async function generateSignatureWithOKXWallet(params: GenerateSignaturePa | |
return await generateWeb3Signature({ ...params, provider: 'okx_wallet' }); | ||
} | ||
|
||
export async function generateSignatureWithBaseWallet(params: GenerateSignatureParams): Promise<string> { | ||
return await generateWeb3Signature({ ...params, provider: 'base_wallet' }); | ||
} | ||
jacekradko marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
async function getEthereumProvider(provider: Web3Provider) { | ||
if (provider === 'coinbase_wallet') { | ||
if (__BUILD_DISABLE_RHC__) { | ||
|
@@ -90,6 +98,22 @@ async function getEthereumProvider(provider: Web3Provider) { | |
}); | ||
return sdk.getProvider(); | ||
} | ||
if (provider === 'base_wallet') { | ||
if (__BUILD_DISABLE_RHC__) { | ||
clerkUnsupportedEnvironmentWarning('Base Wallet'); | ||
return null; | ||
} | ||
|
||
try { | ||
const { createBaseAccountSDK } = await import('@base-org/account'); | ||
const sdk = createBaseAccountSDK({ | ||
appName: typeof document !== 'undefined' ? document.title || 'Clerk' : 'Clerk', | ||
}); | ||
return sdk.getProvider(); | ||
Comment on lines
+108
to
+112
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🙃 Just make sure that this doesn't wind up in the No RHC/Chrome Extension build with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
} catch { | ||
return null; | ||
} | ||
} | ||
|
||
const injectedWeb3Providers = getInjectedWeb3Providers(); | ||
return injectedWeb3Providers.get(provider); | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.