-
Notifications
You must be signed in to change notification settings - Fork 376
chore(e2e): Add test cases for billing buttons #6573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
519ce73
feat(vue,astro): Add Billing buttons
panteliselef 35f7ecf
chore(e2e): Add test cases for billing buttons
panteliselef e9a2f02
Revert "feat(vue,astro): Add Billing buttons"
panteliselef eb5db28
exclude astro and vue
panteliselef e00dea4
update module resolution
panteliselef File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@clerk/clerk-js': patch | ||
--- | ||
|
||
Add class `cl-planDetails-root` to the parent div element that containes the plan details drawer. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@clerk/testing': patch | ||
--- | ||
|
||
Add `planDetails` to the page details object. |
17 changes: 17 additions & 0 deletions
17
integration/templates/next-app-router/src/app/billing/checkout-btn/page.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import { SignedIn } from '@clerk/nextjs'; | ||
import { CheckoutButton } from '@clerk/nextjs/experimental'; | ||
|
||
export default function Home() { | ||
return ( | ||
<main> | ||
<SignedIn> | ||
<CheckoutButton | ||
planId='cplan_2wMjqdlza0hTJc4HLCoBwAiExhF' | ||
planPeriod='month' | ||
> | ||
Checkout Now | ||
</CheckoutButton> | ||
</SignedIn> | ||
</main> | ||
); | ||
} |
9 changes: 9 additions & 0 deletions
9
integration/templates/next-app-router/src/app/billing/plan-details-btn/page.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
import { PlanDetailsButton } from '@clerk/nextjs/experimental'; | ||
|
||
export default function Home() { | ||
return ( | ||
<main> | ||
<PlanDetailsButton planId='cplan_2wMjqdlza0hTJc4HLCoBwAiExhF'>Plan details</PlanDetailsButton> | ||
</main> | ||
); | ||
} |
9 changes: 9 additions & 0 deletions
9
integration/templates/next-app-router/src/app/billing/subscription-details-btn/page.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
import { SubscriptionDetailsButton } from '@clerk/nextjs/experimental'; | ||
|
||
export default function Home() { | ||
return ( | ||
<main> | ||
<SubscriptionDetailsButton>Subscription details</SubscriptionDetailsButton> | ||
</main> | ||
); | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
packages/testing/src/playwright/unstable/page-objects/planDetails.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
import type { EnhancedPage } from './app'; | ||
import { common } from './common'; | ||
|
||
export const createPlanDetailsPageObject = (testArgs: { page: EnhancedPage }) => { | ||
const { page } = testArgs; | ||
const self = { | ||
...common(testArgs), | ||
waitForMounted: (selector = '.cl-planDetails-root') => { | ||
return page.waitForSelector(selector, { state: 'attached' }); | ||
}, | ||
root: page.locator('.cl-planDetails-root'), | ||
}; | ||
return self; | ||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix typo and tighten wording in changeset entry
Correct “containes” → “contains” and simplify phrasing.
Apply this diff:
📝 Committable suggestion
🧰 Tools
🪛 LanguageTool
[grammar] ~5-~5: There might be a mistake here.
Context: ... that containes the plan details drawer.
(QB_NEW_EN)
🤖 Prompt for AI Agents