Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/dull-paws-march.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@clerk/clerk-js': patch
'@clerk/types': patch
---

Display organization slug based on environment settings
9 changes: 9 additions & 0 deletions packages/clerk-js/src/core/resources/OrganizationSettings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ export class OrganizationSettings extends BaseResource implements OrganizationSe
enrollmentModes: [],
defaultRole: null,
};
slug: {
disabled: boolean;
} = {
disabled: false,
};
enabled: boolean = false;
maxAllowedMemberships: number = 1;
forceOrganizationSelection!: boolean;
Expand All @@ -42,6 +47,10 @@ export class OrganizationSettings extends BaseResource implements OrganizationSe
this.domains.defaultRole = this.withDefault(data.domains.default_role, this.domains.defaultRole);
}

if (data.slug) {
this.slug.disabled = this.withDefault(data.slug.disabled, this.slug.disabled);
}

this.enabled = this.withDefault(data.enabled, this.enabled);
this.maxAllowedMemberships = this.withDefault(data.max_allowed_memberships, this.maxAllowedMemberships);
this.forceOrganizationSelection = this.withDefault(
Expand Down
11 changes: 10 additions & 1 deletion packages/clerk-js/src/test/fixture-helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -342,13 +342,22 @@ const createOrganizationSettingsFixtureHelpers = (environment: EnvironmentJSON)
const withForceOrganizationSelection = () => {
os.force_organization_selection = true;
};
const withOrganizationSlug = (enabled = false) => {
os.slug.disabled = !enabled;
};

const withOrganizationDomains = (modes?: OrganizationEnrollmentMode[], defaultRole?: string) => {
os.domains.enabled = true;
os.domains.enrollment_modes = modes || ['automatic_invitation', 'manual_invitation'];
os.domains.default_role = defaultRole ?? null;
};
return { withOrganizations, withMaxAllowedMemberships, withOrganizationDomains, withForceOrganizationSelection };
return {
withOrganizations,
withMaxAllowedMemberships,
withOrganizationDomains,
withForceOrganizationSelection,
withOrganizationSlug,
};
};

const createBillingSettingsFixtureHelpers = (environment: EnvironmentJSON) => {
Expand Down
3 changes: 3 additions & 0 deletions packages/clerk-js/src/test/fixtures.ts
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,9 @@ const createBaseOrganizationSettings = (): OrganizationSettingsJSON => {
enabled: false,
enrollment_modes: [],
},
slug: {
disabled: true,
},
} as unknown as OrganizationSettingsJSON;
};

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { useOrganization, useOrganizationList } from '@clerk/shared/react';
import type { CreateOrganizationParams, OrganizationResource } from '@clerk/types';
import React from 'react';

import { useEnvironment } from '@/ui/contexts';
import { useCardState, withCardStateProvider } from '@/ui/elements/contexts';
import { Form } from '@/ui/elements/Form';
import { FormButtonContainer } from '@/ui/elements/FormButtons';
Expand Down Expand Up @@ -33,6 +34,11 @@ type CreateOrganizationFormProps = {
headerTitle?: LocalizationKey;
headerSubtitle?: LocalizationKey;
};
/**
* @deprecated
* This prop will be removed in a future version.
* Configure whether organization slug is enabled via the Clerk Dashboard under Organization Settings.
*/
hideSlug?: boolean;
};

Expand All @@ -45,6 +51,7 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
userMemberships: organizationListParams.userMemberships,
});
const { organization } = useOrganization();
const { organizationSettings } = useEnvironment();
const [file, setFile] = React.useState<File | null>();

const nameField = useFormControl('name', '', {
Expand All @@ -62,6 +69,9 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
const dataChanged = !!nameField.value;
const canSubmit = dataChanged;

// Environment setting takes precedence over prop
const organizationSlugEnabled = !organizationSettings.slug.disabled && !props.hideSlug;

const onSubmit = async (e: React.FormEvent) => {
e.preventDefault();
if (!canSubmit) {
Expand All @@ -75,7 +85,7 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
try {
const createOrgParams: CreateOrganizationParams = { name: nameField.value };

if (!props.hideSlug) {
if (organizationSlugEnabled) {
createOrgParams.slug = slugField.value;
}

Expand Down Expand Up @@ -188,7 +198,7 @@ export const CreateOrganizationForm = withCardStateProvider((props: CreateOrgani
ignorePasswordManager
/>
</Form.ControlRow>
{!props.hideSlug && (
{organizationSlugEnabled && (
<Form.ControlRow elementId={slugField.id}>
<Form.PlainInput
{...slugField.props}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -80,35 +80,169 @@ describe('CreateOrganization', () => {
expect(getByRole('heading', { name: 'Create organization', level: 1 })).toBeInTheDocument();
});

it('renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withUser({
email_addresses: ['[email protected]'],
describe('with `hideSlug` prop', () => {
it('renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withUser({
email_addresses: ['[email protected]'],
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);
describe('with organization slug configured on environment', () => {
it('when disabled, renders component without slug field', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(false);
f.withUser({
email_addresses: ['[email protected]'],
});
});

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});

it('when enabled, renders component slug field', async () => {
const { wrapper, fixtures } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
f.withUser({
email_addresses: ['[email protected]'],
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();
it('when enabled and `hideSlug` prop is passed, renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
f.withUser({
email_addresses: ['[email protected]'],
});
});

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));
fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});

it('when disabled and `hideSlug` prop is passed, renders component without slug field', async () => {
const { wrapper, fixtures, props } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(false); // Environment disables slug
f.withUser({
email_addresses: ['[email protected]'],
});
});

fixtures.clerk.createOrganization.mockReturnValue(
Promise.resolve(
getCreatedOrg({
maxAllowedMemberships: 1,
slug: 'new-org-1722578361',
}),
),
);

props.setProps({ hideSlug: true });
const { userEvent, getByRole, queryByText, queryByLabelText, getByLabelText } = render(<CreateOrganization />, {
wrapper,
});

expect(queryByLabelText(/Slug/i)).not.toBeInTheDocument();

await userEvent.type(getByLabelText(/Name/i), 'new org');
await userEvent.click(getByRole('button', { name: /create organization/i }));

await waitFor(() => {
expect(queryByText(/Invite new members/i)).toBeInTheDocument();
});
});
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ describe('OrganizationList', () => {
it('hides the personal account with no data to list', async () => {
const { wrapper, props } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
f.withUser({
email_addresses: ['[email protected]'],
organization_memberships: [{ name: 'Org1', id: '1', role: 'admin' }],
Expand Down Expand Up @@ -210,6 +211,7 @@ describe('OrganizationList', () => {
it('display CreateOrganization within OrganizationList', async () => {
const { wrapper } = await createFixtures(f => {
f.withOrganizations();
f.withOrganizationSlug(true);
f.withUser({
email_addresses: ['[email protected]'],
create_organization_enabled: true,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import { useOrganizationList } from '@clerk/shared/react';
import type { CreateOrganizationParams } from '@clerk/types';

import { useEnvironment } from '@/ui/contexts';
import { useTaskChooseOrganizationContext } from '@/ui/contexts/components/SessionTasks';
import { localizationKeys } from '@/ui/customizables';
import { useCardState } from '@/ui/elements/contexts';
Expand All @@ -25,6 +27,7 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
const { createOrganization, isLoaded, setActive } = useOrganizationList({
userMemberships: organizationListParams.userMemberships,
});
const { organizationSettings } = useEnvironment();

const nameField = useFormControl('name', '', {
type: 'text',
Expand All @@ -37,6 +40,8 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
placeholder: localizationKeys('taskChooseOrganization.createOrganization.formFieldInputPlaceholder__slug'),
});

const organizationSlugEnabled = !organizationSettings.slug.disabled;

const onSubmit = async (e: React.FormEvent) => {
e.preventDefault();

Expand All @@ -45,7 +50,13 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
}

try {
const organization = await createOrganization({ name: nameField.value, slug: slugField.value });
const createOrgParams: CreateOrganizationParams = { name: nameField.value };

if (organizationSlugEnabled) {
createOrgParams.slug = slugField.value;
}

const organization = await createOrganization(createOrgParams);

await setActive({
organization,
Expand Down Expand Up @@ -90,15 +101,17 @@ export const CreateOrganizationScreen = (props: CreateOrganizationScreenProps) =
ignorePasswordManager
/>
</Form.ControlRow>
<Form.ControlRow elementId={slugField.id}>
<Form.PlainInput
{...slugField.props}
onChange={event => updateSlugField(event.target.value)}
isRequired
pattern='^(?=.*[a-z0-9])[a-z0-9\-]+$'
ignorePasswordManager
/>
</Form.ControlRow>
{organizationSlugEnabled && (
<Form.ControlRow elementId={slugField.id}>
<Form.PlainInput
{...slugField.props}
onChange={event => updateSlugField(event.target.value)}
isRequired
pattern='^(?=.*[a-z0-9])[a-z0-9\-]+$'
ignorePasswordManager
/>
</Form.ControlRow>
)}

<FormButtonContainer sx={() => ({ flexDirection: 'column' })}>
<Form.SubmitButton
Expand Down
Loading
Loading