-
Notifications
You must be signed in to change notification settings - Fork 422
fix(localizations): Update Hebrew localization placeholders for user input fields #7566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -212,17 +212,17 @@ export const heIL: LocalizationResource = { | |||||
| formFieldInputPlaceholder__apiKeyName: undefined, | ||||||
| formFieldInputPlaceholder__backupCode: undefined, | ||||||
| formFieldInputPlaceholder__confirmDeletionUserAccount: 'מחיקת חשבון', | ||||||
| formFieldInputPlaceholder__emailAddress: undefined, | ||||||
| formFieldInputPlaceholder__emailAddress: 'כתובת האימייל שלך', | ||||||
| formFieldInputPlaceholder__emailAddress_username: undefined, | ||||||
| formFieldInputPlaceholder__emailAddresses: '[email protected], [email protected]', | ||||||
| formFieldInputPlaceholder__firstName: undefined, | ||||||
| formFieldInputPlaceholder__lastName: undefined, | ||||||
| formFieldInputPlaceholder__firstName: 'שם פרטי', | ||||||
| formFieldInputPlaceholder__lastName: 'שם משפחה', | ||||||
| formFieldInputPlaceholder__organizationDomain: undefined, | ||||||
| formFieldInputPlaceholder__organizationDomainEmailAddress: undefined, | ||||||
| formFieldInputPlaceholder__organizationName: undefined, | ||||||
| formFieldInputPlaceholder__organizationName: 'שם הארגון', | ||||||
| formFieldInputPlaceholder__organizationSlug: 'הארגון-שלי', | ||||||
| formFieldInputPlaceholder__password: undefined, | ||||||
| formFieldInputPlaceholder__phoneNumber: undefined, | ||||||
| formFieldInputPlaceholder__password: 'הכנס סיסמה', | ||||||
|
||||||
| formFieldInputPlaceholder__password: 'הכנס סיסמה', | |
| formFieldInputPlaceholder__password: 'הזן סיסמה', |
Copilot
AI
Jan 8, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The placeholder translations lack consistency in style. Some use imperative verbs (הכנס, הזן) while others don't, and some include possessive pronouns (שלך) while others omit them. For better user experience, consider applying a consistent pattern across all placeholders. For example, either use imperatives for all (like Spanish "Ingrese su...") or use simple descriptive phrases for all (like "כתובת אימייל", "שם פרטי", etc.).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word for "email" is inconsistent in the file. Line 215 uses "אימייל" (transliterated), but other parts of the file use 'דוא"ל' (Hebrew acronym for electronic mail, line 237). Consider using the same term consistently throughout the file. The Hebrew acronym 'דוא"ל' is more formal and commonly used in official Israeli contexts.