fix(scripts): pass arguments through wrapper to install.sh #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix argument passing in the install wrapper script so that version specification works correctly when using
bash -s VERSION.Details
Problem: The wrapper script (
scripts/install) was usingbash -c "$(curl ...)"which doesn't forward arguments to the downloaded script. When users ran:curl -fsSL https://clix.sh/install | bash -s v1.1.0The version argument was lost and the latest version was installed instead.
Solution: Changed from:
bash -c "$(curl -fsSL https://clix.sh/install.sh)"to:
This properly forwards all arguments (
$@) toinstall.sh.Related Issues
Follow-up fix for #12
How to Validate
cat scripts/install | bash -s v1.1.0cat scripts/install | bashPre-Merge Checklist
Code Quality
bun run build)bun run typecheck)bun run lint)bun test)Documentation
Commit Standards
Platform Validation
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.