fix: add interactive mode instruction to embedded skills #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ensure embedded skills follow the Guided Interactive Workflow pattern in interactive mode by adding explicit instructions to
getSkillPrompt. This fixes the issue where/event-trackingand other interactive skills skip confirmation/proposal steps and immediately proceed to implementation.Details
Added
INTERACTIVE_MODE_INSTRUCTIONconstant that enforces the Confirm → Propose → Validate → Implement → Verify workflow for embedded skills in interactive mode. The instruction is only applied whenoneShot: false(interactive mode), while command mode behavior remains unchanged. This applies to all embedded skills:event-tracking,integration,user-management,personalization, andapi-triggered-campaigns.How to Validate
bun run devto start interactive mode/event-trackingcommand/integration,/user-management) exhibit same behaviorclix install(command mode) still runs autonomously without asking questionsbun testto verify all tests passPre-Merge Checklist
Code Quality
bun test src/lib/__tests__/skills.test.ts)Commit Standards
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.