datastore: add clear_table and fix drop_table
#3214
+147
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shubham8287
approved these changes
Sep 2, 2025
Co-authored-by: Shubham Mishra <[email protected]> Signed-off-by: Mazdak Farrokhzad <[email protected]>
Shubham8287
reviewed
Sep 2, 2025
gefjon
reviewed
Sep 2, 2025
Comment on lines
+718
to
+727
| committed_state.get_table(table_id).and_then(|table| { | ||
| table_stats.insert( | ||
| table_id, | ||
| TableStats { | ||
| row_count: table.row_count, | ||
| bytes_occupied_overestimate: table.bytes_occupied_overestimate(), | ||
| num_indices: table.num_indices(), | ||
| }, | ||
| ) | ||
| }); |
There was a problem hiding this comment.
This reminds me: do we need to clean up any metrics when a table gets deleted? If there are any metrics that have a table ID in the with_label_values, we'll want to call remove_label_values on them at some point, probably within commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Aternative to and closes #3210.
This version relies on
pending_schema_changes.The first commit adds
clear_tableto the datastore that's efficient and can be exposed to the module ABI in a follow up.The second commit fixes
drop_table.API and ABI breaking changes
None
Expected complexity level and risk
3?
Testing
test_drop_table_is_transactionalis amended to checkTxData.