Resolve misc warnings in C# bindings code #3312
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekhoff
changed the title
This was
linked to
issues
Sep 30, 2025
Closed
bfops
reviewed
Sep 30, 2025
kim
reviewed
Sep 30, 2025
bfops
reviewed
Sep 30, 2025
Closed
Co-authored-by: Zeke Foppa <[email protected]> Signed-off-by: rekhoff <[email protected]>
|
I believe once #3297 is merged, only the changes in |
jdetter
reviewed
Sep 30, 2025
| run: | | ||
| sudo rm -rf /usr/local/lib/android | ||
| sudo docker image prune --all --force | ||
| sudo docker builder prune -a |
There was a problem hiding this comment.
@bfops Instead of clearing some space here do you think we should just move this job to the custom runner which just has more space available? I know we've been running out of space there as well but I think we can fix that issue separately.
There was a problem hiding this comment.
I'm open to that if it "just works". if we end up having to fight more battles, I'd say keep this as-is and maybe leave a TODO for the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This implements a fix for #3304, specifically addressing failures in:
Changes include:
csharp-test.ymlfile with an explicit .NET version to run .NET Tests under, in order to prevent thewasi-experimentalworkload error that occurs when running under .NET 9 due towasi-experimentalonly supported under .NET 8API and ABI breaking changes
No
Expected complexity level and risk
1
Testing