-
Notifications
You must be signed in to change notification settings - Fork 616
spacetime init
rewrite
#3366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
spacetime init
rewrite
#3366
Conversation
c022d34
to
ea0f0f7
Compare
ea0f0f7
to
e536cc3
Compare
10f14ee
to
cc118cc
Compare
This PR is now almost ready for a review with two caveats: I've included TypeScript as a module language, but due to #3327 it obviously is not finalised, so I think this PR should wait for #3227, so I don't have to rip out all of the mentions of module TS, just to introduce it when the other PR is merged I don't really like how the arguments to the subcommand turned out due to leaving the old usage intact. here are the changes in the command output, and honestly I can't really make too much sense out of it, even though I implemented the new version. The problem is, that now we have legacy
Personally I'd go for two as it would also allow to massively simplify the implementation, but if we really want to keep the functionality then I'd probably try 3. so the message makes more sense The summary of the PR so far:
|
1a87bbf
to
47e5c2d
Compare
This is a draft of the new functionality for
spacetime init
. In order to run it with built-in templates you have to set the path to the config file:In the future it will fetch the list from GH.
A few notes:
spacetime init
does not work at the momentspacetimedb
directory for the server filesmissing --foo
, we will automatically launch interactive mode, which is harder to debug. That's why I think I'd prefer to implement--non-interactive
argument--lang
or--project-path
explicitly, I guess we could run the legacy workflow, but not sure if it's worth it, as the command was marked as unstable anyway