ModuleDef and schema changes to support procedures #3392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit extends various schema and schema-adjacent structures to describe procedures, a new kind of database function which are allowed to perform side effects. This includes extending `RawModuleDefV9` with a way to register `RawProcedureDefV9`s in the `misc_exports`, preserving compatibility with modules that predate procedures. The module validation path is reorganized somewhat to validate various properties related to procedures while preserving code clarity and maintainability. Additionally, the `ArgsTuple` machinery for ser/de-ing reducer arguments using the argument type as a seed is extended to also support procedure arguments. All of this is currently unused.
Centril
reviewed
Oct 15, 2025
Prior to this commit, we never actually checked that reducers had unique names. My new `check_function_names_are_unique` assumed this invariant, but we were silently ignoring duplicate reducer names. With this commit, `check_function_names_are_unique` actually validates uniqueness not only between the two sets, but within them. This commit also adds three tests for the three possible ways to have a duplicate name: two reducers, two procedures, or one of each.
joshua-spacetime
approved these changes
Oct 15, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This commit extends various schema and schema-adjacent structures to describe procedures, a new kind of database function which are allowed to perform side effects.
This includes extending
RawModuleDefV9with a way to registerRawProcedureDefV9s in themisc_exports, preserving compatibility with modules that predate procedures.The module validation path is reorganized somewhat to validate various properties related to procedures while preserving code clarity and maintainability.
Additionally, the
ArgsTuplemachinery for ser/de-ing reducer arguments using the argument type as a seed is extended to also support procedure arguments.All of this is currently unused.
API and ABI breaking changes
Additive and backwards-compatible additions to
RawModuleDefV9and friends.Expected complexity level and risk
2 - some minor complexity in schema validation which may have gotten borked in a merge at some point.
Testing
Unsure what tests would be useful, open to suggestions from reviewers.