Typescript query builder #3630
Draft
Typescript query builder #3630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
76
to
80
| firstQuery.semijoinTo( | ||
| ctx.queryBuilder.order, | ||
| p => p.age, | ||
| o => o.item_name | ||
| ); |
Collaborator
There was a problem hiding this comment.
I thought we decided on
.semijoin(ctx.queryBuilder.order, (p, o) => eq(p.age, o.item_name));
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This introduces a query builder for typescript modules. It is available as
ReducerCtx.queryBuilder, but it might make more sense to rename that toschema. There are some examples of how to build queries inquery.test-d.tsandquery.test.ts.There is more type-safety to be added (ensuring
eqis used on comparable types, and only allowing semijoins to use indexed columns), but those changes should only require changing some type parameters.API and ABI breaking changes
This is adding a new query builder API on the module side, which won't actually be useful until we can use them in views.
Expected complexity level and risk
1.5.
Testing
There are tests of the emitted sql in
query.test.ts, but at some point we should add end-to-end tests to make sure that we can parse those queries in the query engine.