[TS] Implement basic procedure calling #3649
Open
+312
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
force-pushed
the
noa/ts-procedures
branch
from
845d892 to
f03b4db
Compare
Centril
reviewed
Nov 17, 2025
| } | ||
|
|
||
| match call_result { | ||
| let trapped = call_result.is_err(); |
Contributor
There was a problem hiding this comment.
Is this correct? Trapped means "drop instance" in this case, and for reducers, the logic is different.
Collaborator
Author
There was a problem hiding this comment.
Correct, but this behavior was already in master, and I couldn't figure out whether or not it was intentional and correct. I figure if we want to change it in a follow-up it'll be pretty easy.
coolreader18
force-pushed
the
noa/ts-procedures
branch
2 times, most recently
from
f4d7194 to
ffd7bc9
Compare
coolreader18
force-pushed
the
noa/ts-procedures
branch
from
ffd7bc9 to
a532856
Compare
This was
linked to
issues
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Implements
__call_procedure__in the TS bindings and host.Expected complexity level and risk
2
Testing