Skip to content

Conversation

@mamcx
Copy link
Contributor

@mamcx mamcx commented Nov 14, 2025

Description of Changes

Closes #3507.

Add the database identity and if the error is trap.

Expected complexity level and risk

1

Testing

  • Manual inspection of metric, displays now:
# TYPE spacetime_worker_wasm_instance_errors_total counter
spacetime_worker_wasm_instance_errors_total{caller_connection_id="bd7cc4bd2a2ed433524394207d55f948",caller_identity="c200da2d6ddb6c0beef0bbaafacffe5f0649c86b8d19411e3219066a6d0e5123",database_identity="c20076c95fc2e78175d8d8eec4aeb7f181f812279e03abadd21c878988478dc8",module_hash="50e173de3e047eaa422f3bbac12019e085472ec8c324dbe9d30f4a068f3be0db",reducer_symbol="panic_err",trapped="true"} 1

@mamcx mamcx self-assigned this Nov 14, 2025
@mamcx mamcx added the release-any To be landed in any release window label Nov 14, 2025
@mamcx mamcx requested a review from drogus November 14, 2025 16:10
@drogus
Copy link
Collaborator

drogus commented Nov 14, 2025

I think we've been working on the same thing, I opened two PRs regarding errors:

#3614
#3613

#3614 also removes some labels cause of high cardinality

@mamcx
Copy link
Contributor Author

mamcx commented Nov 14, 2025

I think we've been working on the same thing, I opened two PRs regarding errors:

Oh, then I closed this one. Please add in the other PRs that you will close the issue

@mamcx mamcx closed this Nov 14, 2025
@drogus
Copy link
Collaborator

drogus commented Nov 14, 2025

Sure, also sorry, I didn't know that the other PR exists, I worked on it as a part of web dashboard overview

@mamcx mamcx deleted the mamcx/track-prometheus-module-errors branch November 14, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-any To be landed in any release window

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add error rate + panic rate metrics to prometheus

3 participants