-
Notifications
You must be signed in to change notification settings - Fork 644
Add C# client SDK procedures #3666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…adds namespace resolution for Reducer types as well
Centril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a C# guy, but this looks good to me.
rekhoff
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Worked through any questions directly. Locally tested the regression test and everything passes. Approved.
Description of Changes
Closes: #3533
Updated the C# SDK to handle procedures and procedure callbacks in a similar fashion to the Rust client as well as added the codegen to support it.
API and ABI breaking changes
N/A
Expected complexity level and risk
2 - This adds a new testing frame that should be removed once procedures are handled with C# module bindings
Testing
Added /sdks/csharp/examples~/regression-tests/procedure-client to match modules/sdk-test-procedure which we can roll into the standard regression-tests once C# supports the procedure attribute.