Add Unreal client SDK procedures #3667
Open
+6,044
−530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rekhoff
approved these changes
Nov 19, 2025
Contributor
rekhoff
left a comment
rekhoff
left a comment
There was a problem hiding this comment.
Looks good. The tests look good too, and seem to provide a solid amount of coverage. Testing locally, all tests pass.
…cedure # Conflicts: # crates/codegen/src/unrealcpp.rs # sdks/unreal/tests/TestClient/Source/TestClient/Private/ModuleBindings/SpacetimeDBClient.g.cpp # sdks/unreal/tests/TestClient/Source/TestClient/Public/ModuleBindings/SpacetimeDBClient.g.h # sdks/unreal/tests/TestClient/Source/TestClient/Public/ModuleBindings/Types/EnumWithPayloadType.g.h
Contributor
Author
|
@rekhoff - Can you give this a quick look for the updated tests and repair for passing ProcedureEventContext to procedure callbacks? |
Contributor
Reviewed changes called out here, and tested locally. Was able to get all local tests passing. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Closes: #3535
Updated the Unreal SDK to handle procedures and procedure callbacks as closely matched to Rust + C#.
API and ABI breaking changes
N/A
Expected complexity level and risk
2 - This adds a new testing frame that should be removed once procedures are handled in /modules/sdk-test.
Testing
Added a mirror of /sdks/unreal/tests/TestClient to use the new /modules/sdk-test-procedure which adds complexity we'll want to remove.