Conversation
vemv
commented
Nov 17, 2021
| unit-tests: | ||
| $(CASK) exec buttercup -L . | ||
|
|
||
| test: unit-tests integration-tests |
Member
Author
There was a problem hiding this comment.
refactoring based on https://github.com/clojure-emacs/clj-refactor.el/pull/493/files#r709812770
(@bbatsov)
bbatsov
reviewed
Nov 18, 2021
|
|
||
| (let ((files (directory-files default-directory t | ||
| "\\`[^.].*\\.el\\'" t))) | ||
| (when nil ;; See https://github.com/clojure-emacs/clj-refactor.el/issues/491 |
Member
There was a problem hiding this comment.
I think you can also set some env var and just disable this on the CI. I think it's not a bad idea for people to be able to run this locally.
bbatsov
reviewed
Nov 18, 2021
| (require 'paredit) | ||
| (require 'clj-refactor) | ||
|
|
||
| ;; NOTE: please remember, without an `it` block, your tests will not be run! |
Member
There was a problem hiding this comment.
You also link to buttercup's docs here.
Member
|
Looks good overall, feel free to ignore my remarks. |
Reflects the decisions we made over #493. Code has been copied as is, except for the unit tests in question, which are for `cljr--ns-name` (as a random example that I picked).
Member
Author
|
Amended w/ feedback, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reflects the decisions we made over #493 (which I've postponed a bit).
Code has been copied as is, except for the unit tests in question, which are for
cljr--ns-name(as a random example that I picked).