Skip to content

Handle BrokenPipeError #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2017
Merged

Handle BrokenPipeError #15

merged 1 commit into from
Sep 15, 2017

Conversation

daveyarwood
Copy link
Contributor

Fixes #14. I have this code running locally in my Neovim/deoplete/fireplace setup and it appears to do the trick.

Note that this only fixes the issue that I was experiencing with fireplace. Assuming the problem also crops up with acid, similar code will need to be added to acid.py, or better yet, the "remove the connection if a BrokenPipeError happens" bit could be factored out and used by both implementations.

@SevereOverfl0w
Copy link
Member

SevereOverfl0w commented Sep 13, 2017 via email

@daveyarwood
Copy link
Contributor Author

The rethrow in cider.py is mistaken
I'm guessing?

That one is the default behavior -- that way, if the caller doesn't provide an on_error callback, the error is still thrown.

I've not seen string joining within brackets before.

That was new to me, too. I hadn't coded in Python in a while and forgot how multiline strings work, apparently that's the preferred way to do it.

@SevereOverfl0w SevereOverfl0w merged commit 1ccd8f0 into clojure-vim:master Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncaught BrokenPipeError makes Neovim+deoplete unusable while error message is printing
2 participants