Handle BrokenPipeError #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will merge tomorrow, and open issues. The rethrow in cider.py is mistaken
I'm guessing?
I've not seen string joining within brackets before.
…On 13 Sep 2017 20:33, "Dave Yarwood" ***@***.***> wrote:
Fixes #14 <#14>. I
have this code running locally in my Neovim/deoplete/fireplace setup and it
appears to do the trick.
Note that this only fixes the issue that I was experiencing with
fireplace. Assuming the problem also crops up with acid, similar code will
need to be added to acid.py, or better yet, the "remove the connection if a
BrokenPipeError happens" bit could be factored out and used by both
implementations.
------------------------------
You can view, comment on, or merge this pull request online at:
#15
Commit Summary
- catch BrokenPipeError and handle with a provided callback
File Changes
- *M* pythonx/async_clj_omni/cider.py
<https://github.com/clojure-vim/async-clj-omni/pull/15/files#diff-0>
(25)
- *M* pythonx/async_clj_omni/fireplace.py
<https://github.com/clojure-vim/async-clj-omni/pull/15/files#diff-1>
(13)
Patch Links:
- https://github.com/clojure-vim/async-clj-omni/pull/15.patch
- https://github.com/clojure-vim/async-clj-omni/pull/15.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#15>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AF2h2lQ7U9ps1kCemHQNm853bXjNFYwsks5siC4SgaJpZM4PWnOz>
.
|
That one is the default behavior -- that way, if the caller doesn't provide an
That was new to me, too. I hadn't coded in Python in a while and forgot how multiline strings work, apparently that's the preferred way to do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14. I have this code running locally in my Neovim/deoplete/fireplace setup and it appears to do the trick.
Note that this only fixes the issue that I was experiencing with fireplace. Assuming the problem also crops up with acid, similar code will need to be added to acid.py, or better yet, the "remove the connection if a BrokenPipeError happens" bit could be factored out and used by both implementations.