Update scan-dirs to no longer throw #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I merged, but I should have done more testing.
Two problems when I run this new code:
It appears to have deleted milliseconds-since-epoch, probably because it
was no longer needed in modified-files.
However, it is still needed in update-files. Loading throws with an
'unable to resolve symbol' error.
After fixing that, testing fails for tests t-repl-scan-twice and
t-repl-scan-after-file-modified.
Same error for both: System.InvalidCastException: Unable to cast object
of type 'System.Int64' to type 'System.DateTime'.
You did not run into any errors?
…On Mon, Nov 18, 2024 at 7:50 PM Brandon Correa ***@***.***> wrote:
- Updated scan-dirs to no longer throw when invoked
- Added GitHub test workflow
------------------------------
You can view, comment on, or merge this pull request online at:
#3
Commit Summary
- 6aaae53
<6aaae53>
Update dir/modified-files function to no longer throw
- f3bc981
<f3bc981>
Add github test workflow
File Changes
(3 files <https://github.com/clojure/clr.tools.namespace/pull/3/files>)
- *A* .github/workflows/test.yml
<https://github.com/clojure/clr.tools.namespace/pull/3/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88>
(19)
- *M* src/main/clojure/clojure/tools/namespace/dir.clj
<https://github.com/clojure/clr.tools.namespace/pull/3/files#diff-3fadd5136845d2fd7762bce2eb87d4f077705a2c9cb5263a6a4eeae3c1cc9bc6>
(10)
- *M* src/test/clojure/clojure/tools/namespace/dir_test.clj
<https://github.com/clojure/clr.tools.namespace/pull/3/files#diff-c272300769cd36de2d5af2195684533960f58e0e380404938467e05480c22ac1>
(13)
Patch Links:
- https://github.com/clojure/clr.tools.namespace/pull/3.patch
- https://github.com/clojure/clr.tools.namespace/pull/3.diff
—
Reply to this email directly, view it on GitHub
<#3>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAUVZKR33GVFYEFQYQDDJT2BKDOVAVCNFSM6AAAAABSA42QUCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGY3TANBQGY3TCNY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
There were merge conflicts, so it is also possible I screwed things up when
editing out the conflicts.
…On Sun, Jul 27, 2025 at 10:14 AM David Miller ***@***.***> wrote:
I merged, but I should have done more testing.
Two problems when I run this new code:
It appears to have deleted milliseconds-since-epoch, probably because it
was no longer needed in modified-files.
However, it is still needed in update-files. Loading throws with an
'unable to resolve symbol' error.
After fixing that, testing fails for tests t-repl-scan-twice and
t-repl-scan-after-file-modified.
Same error for both: System.InvalidCastException: Unable to cast object
of type 'System.Int64' to type 'System.DateTime'.
You did not run into any errors?
On Mon, Nov 18, 2024 at 7:50 PM Brandon Correa ***@***.***>
wrote:
>
> - Updated scan-dirs to no longer throw when invoked
> - Added GitHub test workflow
>
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> #3
> Commit Summary
>
> - 6aaae53
> <6aaae53>
> Update dir/modified-files function to no longer throw
> - f3bc981
> <f3bc981>
> Add github test workflow
>
> File Changes
>
> (3 files <https://github.com/clojure/clr.tools.namespace/pull/3/files>)
>
> - *A* .github/workflows/test.yml
> <https://github.com/clojure/clr.tools.namespace/pull/3/files#diff-faff1af3d8ff408964a57b2e475f69a6b7c7b71c9978cccc8f471798caac2c88>
> (19)
> - *M* src/main/clojure/clojure/tools/namespace/dir.clj
> <https://github.com/clojure/clr.tools.namespace/pull/3/files#diff-3fadd5136845d2fd7762bce2eb87d4f077705a2c9cb5263a6a4eeae3c1cc9bc6>
> (10)
> - *M* src/test/clojure/clojure/tools/namespace/dir_test.clj
> <https://github.com/clojure/clr.tools.namespace/pull/3/files#diff-c272300769cd36de2d5af2195684533960f58e0e380404938467e05480c22ac1>
> (13)
>
> Patch Links:
>
> - https://github.com/clojure/clr.tools.namespace/pull/3.patch
> - https://github.com/clojure/clr.tools.namespace/pull/3.diff
>
> —
> Reply to this email directly, view it on GitHub
> <#3>, or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAAUVZKR33GVFYEFQYQDDJT2BKDOVAVCNFSM6AAAAABSA42QUCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGY3TANBQGY3TCNY>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
|
|
This commit seems to have fixed the issue. If you revert the revert on master and add this code, things should work again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scan-dirsto no longer throw when invoked