-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support of P-UDN using VMs #159
base: main
Are you sure you want to change the base?
Conversation
I was able to generate some results using the l2bridge binding method in OCP 4.18 but passt method is not stable for this version. I keep this PR as a draft until this feature becomes stable. |
I have added an option for switching from l2bridge and passt binding method. The l2bridge has still the best performance on 4.18.rc5 but passt performance and stability is improving. |
19043f1
to
7b72ba8
Compare
@jtaleric is it ok to merge this one? |
@capolrik can you rebase? sorry! |
Needed to be run on 4.18 and above, support l2bridge or passt binding method
@jtaleric do you have the time for a little review? |
@jtaleric @smalleni @venkataanil, someone has few minutes to review this? |
Thanks for adding the documentation @capolrik |
here is an example of an output:
|
pkg/k8s/kubevirt.go
Outdated
@@ -275,6 +297,7 @@ ssh_deletekeys: false | |||
password: fedora | |||
chpasswd: { expire: False } | |||
runcmd: | |||
- export HOME=/home/fedora |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need this export?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added it when I was troubleshooting the cloudinit process but it should have been remove. Deleting it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see is adding any metadata to let us know the binding in the results. Lets add that to the output of both the CSV and the JSON/ES document.
@jtaleric I have added 'UDN info' which is the udn layer + Binding method as an output, it looks like this:
For pod UDN, it displays only the layer. |
Based on #158
Needs to be run on OCP 4.18 and above.