api: add support for multiple uid/gid idmappings #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, only single mapping for uid/gid is supported. However, for userns, mutiple uid/gid mappings can be setted. This commit follows how fuse-overlayfs support this feature. containers/fuse-overlayfs@3378869 Signed-off-by: Qi Wang <[email protected]>
When running test_clone_fuse_file as non-root, the test will fail.
```
---- transport::fusedev::linux_session::tests::test_clone_fuse_file stdout ----
thread 'transport::fusedev::linux_session::tests::test_clone_fuse_file' panicked at src/transport/fusedev/linux_session.rs:680:20:
called `Result::unwrap()` on an `Err` value: SessionFailure("Unexpected exit code when running fusermount: Some(1)")
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
```
Signed-off-by: Qi Wang <[email protected]>
yawqi
requested review from
bergwolf,
imeoer,
jiangliu,
liubogithub and
eryugey
as code owners
bergwolf
reviewed
Dec 28, 2023
| fn id_remap(&self, ctx: &mut Context) -> io::Result<()> { | ||
| Ok(()) | ||
| } | ||
| fn id_remap(&self, ctx: &mut Context) {} |
There was a problem hiding this comment.
The API change doesn't seem necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, only single uid/gid idmapping supported. However, in userns, multiple idmappings can be setted. Besides, in the fuse-overlayfs project, multiple idmappings are supported.
https://github.com/containers/fuse-overlayfs/blob/18f4d6768ab2178f0147c1bac0ccfd7d44841a56/README.md?plain=1#L16
This commit will be used to support kata-containers/kata-containers#8170. Currently, there is no idmap mount support for virtiofs in kernel side. So the support from the virtiofs server side can be used as a temporary workaround.
This comment containerd/containerd#7063 (comment) provides a way to solve the rootfs' idmapping problem. Although it is not used in their implementation at last, but can be used for us to support userns in kata in the first place.