Skip to content

fix: Handle cloudflare-internal:workers default export #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
penalosa wants to merge 2 commits into from
Closed

fix: Handle cloudflare-internal:workers default export #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c48a1e9
fix: Handle cloudflare-internal:workers default export
penalosa Feb 18, 2026
29263e1
Create pink-teachers-sneeze.md
penalosa Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/pink-teachers-sneeze.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"capnweb": patch
---

fix: Handle `cloudflare-internal:workers` default export
2 changes: 2 additions & 0 deletions src/core.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ if (!Promise.withResolvers) {
}

let workersModule: any = (globalThis as any)[WORKERS_MODULE_SYMBOL];
// Handle cloudflare-internal:workers which exports on `default` instead of named exports
workersModule = workersModule?.default ?? workersModule;
Copy link

@petebacondarwin petebacondarwin Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a chance that this breaks modules that previously had a minimal default export but really wanted to share most exports via named exports?

Copy link

@petebacondarwin petebacondarwin Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see this is explicitly the cloudflare:workers module.
I thought this was generic code for any module.
How does that work for cloudflare:workers-internal then?


export interface RpcTarget {
[__RPC_TARGET_BRAND]: never;
Expand Down
Loading