Make edit and issue buttons less glaring #20370
Conversation
rita3ko
requested review from
kristianfreeman,
kodster28,
pedrosousa,
marciocloudflare,
haleycode,
maxvp,
GregBrimble,
KianNH,
WalshyDev and
a team
as code owners
|
Preview URL: https://2097c9db.preview.developers.cloudflare.com |
|
Howdy and thanks for contributing to our repo. We review internal PRs within 1 week. If it's something urgent or has been sitting without a comment, start a thread in the Developer Docs space internally. |
github-actions
bot
assigned GregBrimble, haleycode, KianNH, kodster28, kristianfreeman, marciocloudflare, maxvp, pedrosousa and WalshyDev
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -7,6 +7,8 @@ import FeedbackPrompt from "../FeedbackPrompt.tsx"; | |||
| --- | |||
|
|
|||
| <Default {...Astro.props} /> | |||
| </br> | |||
There was a problem hiding this comment.
🚫 [eslint] reported by reviewdog 🐶
Parsing error: Unknown token at 275, expected: "<br", actual: "
\n<Fee"
There was a problem hiding this comment.
| </br> | |
| <br /> |
|
@KianNH can you take a look / approve? i think orange is very distracting |
| @@ -7,6 +7,8 @@ import FeedbackPrompt from "../FeedbackPrompt.tsx"; | |||
| --- | |||
|
|
|||
| <Default {...Astro.props} /> | |||
| </br> | |||
There was a problem hiding this comment.
| </br> | |
| <br /> |
| @@ -15,15 +17,15 @@ import FeedbackPrompt from "../FeedbackPrompt.tsx"; | |||
| {Astro.props.editUrl && ( | |||
| <a | |||
| href={Astro.props.editUrl} | |||
| class="h-8 cursor-pointer content-center rounded bg-cl1-brand-orange px-4 text-sm font-medium text-cl1-black" | |||
| class="inline-flex h-8 items-center justify-center gap-2 rounded border border-gray-300 bg-white px-3 text-s font-small text-black hover:bg-gray-50" | |||
There was a problem hiding this comment.
text-s and font-small aren't valid Tailwind classes but if you're happy with how the buttons currently look on the preview than I'd just remove them as they won't be doing anything.
On dark mode, the buttons currently look like this:
You could remove bg-white and hover:bg-gray-50 to just use the normal background colour of the sidebar, or add classes with different colours with the dark: selector.
Summary
Making new edit / issue buttons a little less glaring since righ tnow they're the primary thing that jumps out on the page
Screenshots (optional)
Current:
Proposed:
