Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(Ruleset): Add DeleteRulesetRule() #2833

Merged
merged 6 commits into from
Aug 9, 2024

Conversation

tlimoncelli
Copy link
Contributor

Description

Add DeleteRulesetRule() to delete an individual rule of a ruleset.

Has your change been tested?

This was tested as part of https://github.com/StackExchange/dnscontrol which is currently running with a fork of cloudflare-go. With this PR, DNSControl will no longer require the fork.

Screenshots (if appropriate):

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

Copy link
Contributor

github-actions bot commented Aug 7, 2024

changelog detected ✅

@jacobbednarz jacobbednarz merged commit 5dc300a into cloudflare:master Aug 9, 2024
10 checks passed
@github-actions github-actions bot added this to the v0.102.0 milestone Aug 9, 2024
@jacobbednarz
Copy link
Member

thanks for this @tlimoncelli! if you don't already know, there is a next generation of this library that we're building from our OpenAPI schemas and is automatically kept in sync - https://github.com/cloudflare/cloudflare-go/tree/next (we're at v2.x at the moment but major verisons will be coming thick and fast as we iterate and stabilise the schemas). the rulesets library definitions can be seen at https://github.com/cloudflare/cloudflare-go/blob/next/api.md#rulesets if you're interested.

@tlimoncelli tlimoncelli deleted the tlim_ruleset branch August 9, 2024 13:00
@tlimoncelli
Copy link
Contributor Author

thanks for this @tlimoncelli! if you don't already know, there is a next generation of this library that we're building from our OpenAPI schemas and is automatically kept in sync - https://github.com/cloudflare/cloudflare-go/tree/next (we're at v2.x at the moment but major verisons will be coming thick and fast as we iterate and stabilise the schemas). the rulesets library definitions can be seen at https://github.com/cloudflare/cloudflare-go/blob/next/api.md#rulesets if you're interested.

Thanks! I'll plan on moving to that in the future.

@tlimoncelli
Copy link
Contributor Author

Oops! I should have noticed this earlier.

I see you moved the 2 string parameters into DeleteRulesetRuleParams struct. However the 2 fields aren't exported. How does one create a DeleteRulesetRuleParams?

Copy link
Contributor

This functionality has been released in v0.102.0.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants