Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds snippet support #3364

Closed

Conversation

joshuamsager
Copy link
Contributor

Description

Adds snippet support to the API

I wasn't sure how far away v2/v3 will land and my team would love to have Snippets supported in Terraform. If this is accepted, I can work on getting the Snippet rules next.

Adds:

  • GetSnippet
  • ListSnippets
  • DeleteSnippet
  • PutSnippet

I still have some further testing to do to make sure that these all behave as expected.

Types of changes

What sort of change does your code introduce/modify?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • This change is using publicly documented in cloudflare/api-schemas
    and relies on stable APIs.

@jacobbednarz
Copy link
Member

v2/v3 already has this support so unless you need something specifically in the v0 range, i would recommend using it instead of adding this.

we already support the newer library in the terraform provider as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants