Skip to content

fix: pull-through fallback token scope for registries returning placeholder scope (e.g. ghcr.io) #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ariesy wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −2
Open

fix: pull-through fallback token scope for registries returning placeholder scope (e.g. ghcr.io) #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4182996
fix: fallback token scope for registries that return placeholder scop…
Aug 8, 2026
e56c343
chore: ignore local credentials and build artifacts
Aug 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,7 @@ node_modules
wrangler.toml
wrangler.jsonc
*.tsbuildinfo

# local credentials & build artifacts
registry-credentials.txt
dist/
8 changes: 6 additions & 2 deletions src/registry/http.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,11 @@ export class RegistryHTTPClient implements Registry {
}

const authCtx = authHeaderIntoAuthContext(this.url, authenticateHeader);
if (!authCtx.scope) authCtx.scope = namespace;
// The scope returned by the upstream /v2/ endpoint is only a placeholder
// (e.g. ghcr.io returns "repository:user/image:pull"). Always use the
// namespace from the actual request, otherwise the scope ends up
// double-prefixed (repository:repository:...) and the token request fails.
authCtx.scope = namespace;
switch (authCtx.authType) {
case "bearer":
return await this.authenticateBearer(authCtx);
Expand Down Expand Up @@ -331,7 +335,7 @@ export class RegistryHTTPClient implements Registry {
const params = new URLSearchParams({
service: ctx.service,
// explicitely include that we don't want an offline_token.
scope: `repository:${ctx.scope}:pull,push`,
scope: `repository:${ctx.scope}:pull`,
client_id: "r2registry",
grant_type: this.configuration.username === undefined ? "none" : "password",
password: this.configuration.username === undefined ? "" : this.password(),
Expand Down