fix(cli): fix calculating host python path on windows - #214
Merged
Conversation
|
ProviderModelNotFoundError |
|
@ryanking13 Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
dom96
approved these changes
Aug 18, 2026
dom96
left a comment
dom96
left a comment
Contributor
There was a problem hiding this comment.
Some comments with requested changes but accepting anyway to unblock.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially rollback my change #178, with different fix. The previous change turned out it breaks
pywrangleron windows, since when--pythonis passed, uv considers that they are in the linux environment and installs packages into incorrect directory.This reverts to use
VIRTUAL_ENVvaraible again, but instead wipe out other env variables that can shadow VIRTUAL_ENV variables.