Update default wrangler version to 3.x #238

Eusebiotrigo · 2024-02-29T14:52:32Z

No description provided.

mrbbot · 2024-03-25T14:54:37Z

Hey! 👋 Apologies for not reviewing this sooner. This wrangler version is now out of date again... 😅 We should set up some automation to bump this automatically. 👍 Would you be able to bump this to 3.37.0 and add a changeset similar to 473d9cb?

Eusebiotrigo · 2024-04-02T15:54:46Z

@mrbbot all done, but I'm afraid there is a new version already...

petebacondarwin

Let's just land this. Going forward we should try to implement dependabot to do this automatically ... @nprogers

1000hz · 2024-04-15T15:38:15Z

IMO, we should rework the action to use latest as a last resort default (rather than some hardcoded version number that'll quickly fall out of date), with the following precedence order for determining the wrangler version used by the action:

If the wranglerVersion input was specified, check for an existing wrangler installation in the PATH that satisfies that version. If so, use it. Else, install the specified version and use that instead.
If no wranglerVersion was specified, check for an existing wrangler installation in the PATH (most likely declared in package.json and installed by a previous "install packages" step of the workflow). If so, use it. Else, install wrangler@latest and use that.

RamIdeas · 2024-04-15T16:18:59Z

IMO, we should rework the action to use latest as a last resort default (rather than some hardcoded version number that'll quickly fall out of date), with the following precedence order for determining the wrangler version used by the action:

If the wranglerVersion input was specified, check for an existing wrangler installation in the PATH that satisfies that version. If so, use it. Else, install the specified version and use that instead.

If no wranglerVersion was specified, check for an existing wrangler installation in the PATH (most likely declared in package.json and installed by a previous "install packages" step of the workflow). If so, use it. Else, install wrangler@latest and use that.

Makes sense LGTM 👍

petebacondarwin · 2024-04-17T12:54:40Z

In that case I think we should leave @nevikashah to take a call on this and hand it over to the new team that owns this repo now.

Eusebiotrigo · 2024-04-28T19:34:40Z

Oh! It is 3.52.0 now...

petebacondarwin · 2024-05-02T11:37:42Z

OK - so thinking about this a bit more.

Rather than constantly bumping this, I propose that we land #235 and then set change DEFAULT_WRANGLER_VERSION to latest.

Then the user has two ways to lock this down, either by installing wrangler locally or specifying a version in the wrangler-action config. Otherwise they just get latest.

How do people feel about that?

Cherry · 2024-05-02T13:26:59Z

OK - so thinking about this a bit more.

Rather than constantly bumping this, I propose that we land #235 and then set change DEFAULT_WRANGLER_VERSION to latest.

Then the user has two ways to lock this down, either by installing wrangler locally or specifying a version in the wrangler-action config. Otherwise they just get latest.

How do people feel about that?

latest sounds dangerous and like a breaking change waiting to happen. I think v3 or 3.x.x would be fine though.

petebacondarwin · 2024-05-02T14:12:17Z

latest sounds dangerous and like a breaking change waiting to happen. I think v3 or 3.x.x would be fine though.

Yeah I actually meant to say 3.x when I said latest 😄

This will ensure that wrangler-action will use the latest compatible version of Wrangler if not specified otherwise. There are two ways to lock down the version of Wrangler for this action: - Specify the required version in the action's parameters when implementing it in your Github Workflows. - Add a dependency to a specific version in your package.json of the project being deployed via this action.

petebacondarwin · 2024-05-15T13:56:38Z

src/index.ts

@@ -16,7 +16,7 @@ import { exec, execShell } from "./exec";
 import { checkWorkingDirectory, semverCompare } from "./utils";
 import { getPackageManager } from "./packageManagers";

-const DEFAULT_WRANGLER_VERSION = "3.13.2";
+const DEFAULT_WRANGLER_VERSION = "3.x";


Urgh! We can't set this to a range because we need to compare it with other semantic versions.

We could just go with latest here...?

latest would potentially introduce a breaking chance once 4.x is out though, wouldn't it, if people are just relying on the defaults?

Perhaps looking up the versions on npm and pulling the latest 3.x from there would be best as a first step? If there was a v3 tag, it could be as simple as (pseudo-example) curl https://registry.npmjs.org/wrangler | jq '.["dist-tags"].v3'.

Yeah I briefly played around with looking up the version but it is a bit messy especially if there is no dist-tag, since we would have to iterate over all the versions and find one that best matches the version range.

nprogers · 2024-05-21T16:45:19Z

@petebacondarwin @1000hz to confirm, there is a way around this? a user can specify the version in their package.json? just trying to understand the urgency here

1000hz · 2024-05-21T18:12:39Z

@petebacondarwin @1000hz to confirm, there is a way around this? a user can specify the version in their package.json? just trying to understand the urgency here

Yes, I believe now that #235 has been merged this is much less urgent. We should still eventually figure out what a good fallback default value ought to be though.

JacobMGEvans · 2024-08-06T20:33:20Z

OK - so thinking about this a bit more.

Rather than constantly bumping this, I propose that we land #235 and then set change DEFAULT_WRANGLER_VERSION to latest.

Then the user has two ways to lock this down, either by installing wrangler locally or specifying a version in the wrangler-action config. Otherwise they just get latest.

How do people feel about that?

This was my original intent. This should be the case, at the very least default the minor versions like here const DEFAULT_WRANGLER_VERSION = "3.x";

Cherry · 2024-08-06T20:43:18Z

@JacobMGEvans I don't think the action should ever default to latest - that's a semver problem waiting to happen when v4.x releases and some commands people are using (like for example publish) get removed, or behaviour changed. The action has always pinned a version, so changing that behaviour now (especially to new majors) would be breaking.

The latest version of the 3.x should be fine though.

Edit: saw the edit, and yep agreed. Latest 3.x should be good!

Eusebiotrigo requested a review from a team as a code owner February 29, 2024 14:52

lrapoport-cf assigned mrbbot Mar 21, 2024

mrbbot added the awaiting reporter response label Mar 25, 2024

Eusebiotrigo force-pushed the update/wrangler-to-3.30.0 branch from 20c0b85 to ecefa1e Compare March 25, 2024 20:54

Eusebiotrigo changed the title ~~Update default wrangler version to 3.30.0~~ Update default wrangler version to 3.37.0 Mar 25, 2024

petebacondarwin approved these changes Apr 15, 2024

View reviewed changes

petebacondarwin added awaiting Cloudflare response and removed awaiting reporter response labels Apr 17, 2024

Eusebiotrigo force-pushed the update/wrangler-to-3.30.0 branch from ecefa1e to d0fb805 Compare April 29, 2024 07:33

Eusebiotrigo changed the title ~~Update default wrangler version to 3.37.0~~ Update default wrangler version to 3.52.0 Apr 29, 2024

Taewan-P mentioned this pull request May 5, 2024

[ERROR] No matching export in "node-modules-polyfills:url" for import "URL" #258

Closed

kesar approved these changes May 14, 2024

View reviewed changes

kesar mentioned this pull request May 14, 2024

getting error because of outdated wrangler version #261

Open

Eusebiotrigo and others added 5 commits May 15, 2024 14:04

Update default wrangler version to 3.30.0

1d28a05

Update default wrangler version to 3.37.0

a99a395

Adding changeset

b959cd2

Update default wrangler version to 3.52.0

888649c

petebacondarwin force-pushed the update/wrangler-to-3.30.0 branch from d0fb805 to 9580f80 Compare May 15, 2024 13:07

petebacondarwin changed the title ~~Update default wrangler version to 3.52.0~~ Update default wrangler version to 3.x May 15, 2024

petebacondarwin reviewed May 15, 2024

View reviewed changes

Hugo-C mentioned this pull request Jul 6, 2024

Deploy a simple python worker, invoke error： No loader is configured for ".py" #270

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update default wrangler version to 3.x #238

Update default wrangler version to 3.x #238

Eusebiotrigo commented Feb 29, 2024

mrbbot commented Mar 25, 2024

Eusebiotrigo commented Apr 2, 2024

petebacondarwin left a comment

1000hz commented Apr 15, 2024

RamIdeas commented Apr 15, 2024

petebacondarwin commented Apr 17, 2024

Eusebiotrigo commented Apr 28, 2024

petebacondarwin commented May 2, 2024

Cherry commented May 2, 2024

petebacondarwin commented May 2, 2024

petebacondarwin May 15, 2024

Cherry May 15, 2024

petebacondarwin May 16, 2024

nprogers commented May 21, 2024

1000hz commented May 21, 2024 •

edited

Loading

JacobMGEvans commented Aug 6, 2024 •

edited

Loading

Cherry commented Aug 6, 2024 •

edited

Loading

Update default wrangler version to 3.x #238

Are you sure you want to change the base?

Update default wrangler version to 3.x #238

Conversation

Eusebiotrigo commented Feb 29, 2024

mrbbot commented Mar 25, 2024

Eusebiotrigo commented Apr 2, 2024

petebacondarwin left a comment

Choose a reason for hiding this comment

1000hz commented Apr 15, 2024

RamIdeas commented Apr 15, 2024

petebacondarwin commented Apr 17, 2024

Eusebiotrigo commented Apr 28, 2024

petebacondarwin commented May 2, 2024

Cherry commented May 2, 2024

petebacondarwin commented May 2, 2024

petebacondarwin May 15, 2024

Choose a reason for hiding this comment

Cherry May 15, 2024

Choose a reason for hiding this comment

petebacondarwin May 16, 2024

Choose a reason for hiding this comment

nprogers commented May 21, 2024

1000hz commented May 21, 2024 • edited Loading

JacobMGEvans commented Aug 6, 2024 • edited Loading

Cherry commented Aug 6, 2024 • edited Loading

1000hz commented May 21, 2024 •

edited

Loading

JacobMGEvans commented Aug 6, 2024 •

edited

Loading

Cherry commented Aug 6, 2024 •

edited

Loading