[main] Multiple commands changed to allow canary steps #3400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaopapereira
force-pushed
the
main-restart-canary-steps
branch
2 times, most recently
from
c4d08a4 to
cd7cf35
Compare
a-b
reviewed
Feb 12, 2025
| @@ -89,15 +89,29 @@ var _ = Describe("Continue Deployment", func() { | |||
|
|
|||
| Context("when the continue is successful", func() { | |||
| When("There is a canary deployment", func() { | |||
| It("succeeds", func() { | |||
| helpers.WithHelloWorldApp(func(appDir string) { | |||
| helpers.CF("push", appName, "-p", appDir, "--strategy=canary").Wait() | |||
There was a problem hiding this comment.
question: are we still testing scenario where --strategy=canary, but --instance-steps= is not provided?
There was a problem hiding this comment.
I think we do have tests that test that
joaopapereira
force-pushed
the
main-restart-canary-steps
branch
2 times, most recently
from
92fed62 to
e9f6fe6
Compare
joaopapereira
changed the title
Signed-off-by: João Pereira <[email protected]>
Signed-off-by: João Pereira <[email protected]>
Signed-off-by: João Pereira <[email protected]>
joaopapereira
force-pushed
the
main-restart-canary-steps
branch
from
e9f6fe6 to
3e027ae
Compare
Signed-off-by: João Pereira <[email protected]>
Signed-off-by: João Pereira <[email protected]>
Signed-off-by: João Pereira <[email protected]>
joaopapereira
force-pushed
the
main-restart-canary-steps
branch
from
3e027ae to
42cb1fe
Compare
Signed-off-by: João Pereira <[email protected]>
Signed-off-by: João Pereira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Add
--instance-stepsto the restart, restage, rollback command