Skip to content

[v8] add missing NetworkPolicyV1Endpoint field to Data struct #3418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 27, 2025
Merged

[v8] add missing NetworkPolicyV1Endpoint field to Data struct #3418

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fc3a769
add missing NetworkPolicyV1Endpoint field to Data struct
metskem Feb 19, 2025
226490f
try fixing the test case
metskem Feb 19, 2025
7dac874
try fixing the test case, add missing comma's
metskem Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cf/configuration/coreconfig/config_data.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ type Data struct {
LogCacheEndPoint string
MinCLIVersion string
MinRecommendedCLIVersion string
NetworkPolicyV1Endpoint string
OrganizationFields models.OrganizationFields
PluginRepos []models.PluginRepo
RefreshToken string
Expand Down
8 changes: 6 additions & 2 deletions cf/configuration/coreconfig/config_data_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@ var _ = Describe("V3 Config files", func() {
}
],
"MinCLIVersion": "6.0.0",
"MinRecommendedCLIVersion": "6.9.0"
"MinRecommendedCLIVersion": "6.9.0",
"NetworkPolicyV1Endpoint": "the-network-policy-endpoint"
}`

// V2 by virtue of ConfigVersion only
Expand Down Expand Up @@ -104,7 +105,8 @@ var _ = Describe("V3 Config files", func() {
}
],
"MinCLIVersion": "6.0.0",
"MinRecommendedCLIVersion": "6.9.0"
"MinRecommendedCLIVersion": "6.9.0",
"NetworkPolicyV1Endpoint": "the-network-policy-endpoint"
}`

Describe("NewData", func() {
Expand Down Expand Up @@ -133,6 +135,7 @@ var _ = Describe("V3 Config files", func() {
SSHOAuthClient: "ssh-oauth-client-id",
MinCLIVersion: "6.0.0",
MinRecommendedCLIVersion: "6.9.0",
NetworkPolicyV1Endpoint: "the-network-policy-endpoint",
OrganizationFields: models.OrganizationFields{
GUID: "the-org-guid",
Name: "the-org",
Expand Down Expand Up @@ -185,6 +188,7 @@ var _ = Describe("V3 Config files", func() {
SSHOAuthClient: "ssh-oauth-client-id",
MinCLIVersion: "6.0.0",
MinRecommendedCLIVersion: "6.9.0",
NetworkPolicyV1Endpoint: "the-network-policy-endpoint",
OrganizationFields: models.OrganizationFields{
GUID: "the-org-guid",
Name: "the-org",
Expand Down