Repository navigation
Conversation
In K8s otel-collector and forwarder agent likely do not run on the same machine.
Contributor
Author
|
Tested by deploying this in cf on kind via cloudfoundry/kind-deployment#493 and checking via an external otel-collector-outside-kind that metrics are being forwarded. I think this is a small enough change so we do not need to verify this again on an actual foundation. However, I could test it there again as well if required. |
jorbaum
marked this pull request as ready for review
October 13, 2026 15:25
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make downstream otlp host configurable. Similar to https://github.com/cloudfoundry/loggregator-agent-release/pull/708/changes , but for otlp egress, not for loggregator envelope ingress.
We need this as in kind-deployment otel-collector and forwarder agent do not run on the same machine (see cloudfoundry/kind-deployment#493 ).
Type of change
Testing performed?
Checklist:
mainbranch, or relevant version branchIf you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack