Skip to content

fix(deps): bump source-map-js to 1.2.2 - #5997

Merged
norman-abramovitz merged 4 commits into
cloudfoundry:developfrom
nabramovitz:norm/fix/source-map-js
Oct 8, 2026
Merged

norman-abramovitz merged 4 commits into
cloudfoundry:developfrom
nabramovitz:norm/fix/source-map-js

Conversation

@nabramovitz

Copy link
Copy Markdown
Contributor

What

Move source-map-js from 1.2.1 to 1.2.2 in all four lockfiles. 1.2.1 allows an event-loop denial of service through indexed source-map section offsets (GHSA-68fv-2mgg-jv7q, Dependabot alert #1273).

Lockfile How Requirers
src/frontend/packages/devkit/package-lock.json npm update source-map-js --package-lock-only postcss, sass, source-map-loader
bun.lock overrides entry, beside the other security pins the app build
website/bun.lock overrides entry the docs site build
tools/stb/bun.lock first overrides entry stb

Dependabot flagged only the devkit copy, but the other three resolve the same 1.2.1. 1.2.2 is within every requirer's range, so no other package moves: scripts/lockdiff.mjs shows exactly one entry re-versioned (1.2.1 → 1.2.2) in each lockfile, with nothing added, removed or moved. There is one commit per lockfile.

Related

The other open alert, #1272 (braces, GHSA-vfj7-8cjw-p6xm), has no patched release; 3.0.3 is the latest. braces only reaches the dev-server proxy (http-proxy-middleware → micromatch) and the docs site build, and it only expands glob patterns from our own config. A dismissal request ("tolerable risk") is pending review.

Checks

All run from a clean worktree, installing from the frozen lockfiles:

  • Installed source-map-js is 1.2.2 at the root, in devkit (npm ci) and in stb.
  • make check gate: lint (including the nested-pin guard), 3769 unit tests passed, production build.
  • stb: typecheck, lint, 601 tests, build.
  • make build website succeeds.

AI disclosure (RFC-0047): prepared with AI coding assistance; reviewed by the author.

source-map-js 1.2.1 allows an event-loop denial of service through
indexed source-map section offsets (GHSA-68fv-2mgg-jv7q). 1.2.2 is in
range for postcss, sass and source-map-loader, so only the lock moves:
one entry, nothing else re-resolved.
The root build resolves source-map-js 1.2.1 too (GHSA-68fv-2mgg-jv7q);
Dependabot flagged only the devkit copy. An override, as for the
other security pins, moves the one bun.lock entry and nothing else.
The docs site build resolves source-map-js 1.2.1
(GHSA-68fv-2mgg-jv7q). The override moves the one bun.lock entry.
tools/stb resolves source-map-js 1.2.1 (GHSA-68fv-2mgg-jv7q). Its
first override moves the one bun.lock entry.

@norman-abramovitz norman-abramovitz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LLGTM

@norman-abramovitz
norman-abramovitz marked this pull request as ready for review October 8, 2026 14:49
@norman-abramovitz
norman-abramovitz merged commit 7998c5a into cloudfoundry:develop Oct 8, 2026
24 checks passed
@nabramovitz
nabramovitz deleted the norm/fix/source-map-js branch October 8, 2026 15:21
norman-abramovitz pushed a commit that referenced this pull request Oct 8, 2026
Dependabot PRs carry no fragment, and #5997 landed without one. Note
the source-map-js security fix and the eslint, @types/node, Go group
and docs-site group bumps, plus the browserstack-local removal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants