Git abstraction #310
Draft
Git abstraction #310
+4,714
−3,724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding Kubernetes Java API
…d from config.scm.getScmmConfig; Fix ApplicationConfigurator and comment out if clause
…ess layer for the features(ArgoCD etc)
…ess layer for the features(ArgoCD etc)
- getScmmUri() now reads from config.scm.getScmmConfig() instead of config.scmm -centralSCMUrl now comes from config.multiTenant.scmmConfig.centralScmUrl -provider now comes from config.scm.scmProviderType instead of config.scmm.provider
# Conflicts: # exercises/nginx-validation/Jenkinsfile.ftl # src/main/groovy/com/cloudogu/gitops/config/ApplicationConfigurator.groovy # src/main/groovy/com/cloudogu/gitops/config/Config.groovy # src/main/groovy/com/cloudogu/gitops/features/argocd/ArgoCD.groovy # src/test/groovy/com/cloudogu/gitops/cli/GitopsPlaygroundCliTest.groovy
Updated multi-tenant schema definitions, consolidating configuration for SCM and GitLab. Enhanced CLI options, descriptions, and documentation in README.md for better clarity. Adjusted Groovy classes to align with the updated schemas.
Aligned central SCM configuration defaults in Groovy classes, updated README with detailed multi-tenant options, and refined schema definitions for improved clarity and usability.
…t-gitlab' into feature/abstract-git-gitlab
Contributor
ThomasMichael1811
left a comment
ThomasMichael1811
left a comment
There was a problem hiding this comment.
not finished, yet.
| ### Disclaimer | ||
| The GitLab integration is for **experimental use only** and is **not fully implemented**. Features may be incomplete, unstable, or subject to change. Use at your own discretion. | ||
| The GitLab integration is for **experimental use only** and is **not fully implemented**. Features may be incomplete, unstable, or subject to change. Use at your own discretion. |
| <dependency> | ||
| <groupId>io.kubernetes</groupId> | ||
| <artifactId>client-java</artifactId> | ||
| <version>24.0.0</version> |
Contributor
There was a problem hiding this comment.
please move version into properties section
|
|
||
| # Install ArgoCD Operator CRDs and components | ||
| kubectl kustomize config/default | kubectl create -f - || true | ||
| rm -Rf ../argocd-operator/ |
Contributor
There was a problem hiding this comment.
Suggested change
| rm -Rf ../argocd-operator/ | |
| rm -Rf ../argocd-operator/ | |
| cd .. |
| import com.cloudogu.gitops.utils.CommandExecutor | ||
| import com.cloudogu.gitops.utils.FileSystemUtils | ||
| import com.cloudogu.gitops.utils.K8sClient | ||
| import com.cloudogu.gitops.utils.NetworkingUtils |
Contributor
There was a problem hiding this comment.
please organize imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.