Skip to content

chore(deps): preparation for react 19 (phase 2) #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 4, 2025
Merged

chore(deps): preparation for react 19 (phase 2) #864

merged 3 commits into from
Apr 4, 2025

Conversation

mark-karnaukh-extern-sap
Copy link
Contributor

@mark-karnaukh-extern-sap mark-karnaukh-extern-sap commented Apr 1, 2025 •
edited
Loading

Summary

Changes Made

  • Delete Deprecated JS components (unused) 319d17b.
  • Apply react-19 codemods and provide manual fixes 4501594.
  • Remove prop-types as React 19 no longer requires them 4501594.
  • Upgrade TypeScript to the latest version across all apps and packages in monorepo (postponed - discussed with @barsukov)

Related Issues

Screenshots (if applicable)

Testing Instructions

  1. npm i
  2. npm run TASK

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 309a377

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 1, 2025 •
edited
Loading

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-04-04 08:29 UTC

@mark-karnaukh-extern-sap mark-karnaukh-extern-sap changed the title chore(deps): remove unused js components (deprecated) chore(deps): preparation for react 19 (phase 2) Apr 1, 2025
@mark-karnaukh-extern-sap mark-karnaukh-extern-sap added Technical Debt This is the technical debt label, we need to fix it package All tasks related to package under packages/ app Any app that is not specific label that lives under apps/ labels Apr 1, 2025
@mark-karnaukh-extern-sap mark-karnaukh-extern-sap marked this pull request as ready for review April 3, 2025 10:15
@mark-karnaukh-extern-sap mark-karnaukh-extern-sap mentioned this pull request Apr 3, 2025
Closed
7 tasks
barsukov
barsukov approved these changes Apr 3, 2025
View reviewed changes
Copy link
Contributor

@barsukov barsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM lets go

@barsukov barsukov merged commit 6b65418 into main Apr 4, 2025
15 checks passed
@barsukov barsukov deleted the mark-831-phase-2-preparation-for-react-19 branch April 4, 2025 08:28
ArtieReus pushed a commit that referenced this pull request May 6, 2025
@mark-karnaukh-extern-sap
chore(deps): preparation for react 19 (phase 2) (#864)
2d18307 
* chore(deps): remove unused js components (deprecated)

* chore(deps): remove prop-types usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barsukov barsukov barsukov approved these changes

@andypf andypf andypf approved these changes

@franzheidl franzheidl Awaiting requested review from franzheidl franzheidl is a code owner

Assignees
No one assigned
Labels
app Any app that is not specific label that lives under apps/ package All tasks related to package under packages/ Technical Debt This is the technical debt label, we need to fix it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mark-karnaukh-extern-sap @barsukov @andypf