Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add default_tags #1025

Closed
wants to merge 7 commits into from
Closed

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Apr 28, 2024

what

  • add default_tags
  • self reviewed

why

  • Consistent tagging without needing to try
  • Take advantage of the fixed default_tags in aws v5 provider

references

@nitrocode nitrocode requested review from a team as code owners April 28, 2024 19:12
@osterman
Copy link
Member

osterman commented Oct 3, 2024

@nitrocode this looks interesting, but it's too risky to rollout en masse. We're actively working on rolling out new testing infrastructure for components and will be moving them individually to a new GitHub org.

Additionally, by enabling this, it makes it impossible within a component to not assign certain tags to resources.

There is a workaround, if you would still like this behavior.

@osterman osterman closed this Oct 3, 2024
@nitrocode
Copy link
Member Author

Interesting. I wonder why anyone would not want to tag a resource.

I'll check that out. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants