Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQS module - replace relative path #973

Closed
wants to merge 1 commit into from

Conversation

Aayushadh
Copy link
Contributor

in sqs-queue module changed relative path with absolute path, as it was giving error when used with atmos , pulled it using vendor pull.

what

  • in sqs-queue module changed relative path with absolute path

why

  • it was giving error when used with atmos , pulled it using vendor pull.

references

in sqs-queue module changed relative path with absolute path, as it was giving error when used with atmos , pulled it using vendor pull.
@Aayushadh Aayushadh requested review from a team as code owners February 2, 2024 04:58
@goruha
Copy link
Member

goruha commented Oct 1, 2024

@Aayushadh, thanks for your PR.
Unfortunately, we can not accept it because it makes the module reference to a specific tag.
The sqs_queue component is self-contained and should use the internal submodule terraform-aws-sqs-queue, which is compatible with a component version and referenced by a relative path.

What was the idea behind referencing a specific version instead of updating the whole sqs_queuecomponent to version 1.398.0?

@goruha goruha closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants