chore: Include missing folders needed for themeable artifact #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
=======================================
Coverage 96.17% 96.17%
=======================================
Files 29 29
Lines 679 679
Branches 114 114
=======================================
Hits 653 653
Misses 26 26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
michaeldowseza
force-pushed
the
components-themeable
branch
2 times, most recently
from
9b1e28c to
f1de511
Compare
- Include required files to create a themeable package
michaeldowseza
force-pushed
the
components-themeable
branch
from
f1de511 to
b54e254
Compare
michaeldowseza
changed the title
YueyingLu
approved these changes
Aug 21, 2025
michaeldowseza
commented
Aug 25, 2025
| @@ -0,0 +1,8 @@ | |||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
There was a problem hiding this comment.
Same as components package
| // SPDX-License-Identifier: Apache-2.0 | ||
| import { join } from "node:path"; | ||
|
|
||
| import { buildThemedComponents as themingCoreBuild } from "@cloudscape-design/theming-build"; |
There was a problem hiding this comment.
Same as components package
| baseThemeId?: string; | ||
| } | ||
|
|
||
| export function buildThemedComponents({ theme, outputDir, baseThemeId }: BuildThemedComponentsParams): Promise<void> { |
There was a problem hiding this comment.
We might want to consider an option to allow overriding the specific component imports so this can use the themed components as its peer dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates a components-themeable directory in the lib folder similar to what is created in the components package.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.