Skip to content

Conversation

TrevorBurnham
Copy link
Contributor

This commit replaces barrel imports like

import { range } from 'lodash'

with direct imports like

import range from 'lodash/range'

All of these imports are in test code (Lodash is a devDependency only), so this won't affect the build. But it will make code style more consistent, and it should slightly improve test performance.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

This commit replaces barrel imports like

```
import { range } from 'lodash'
```

with direct imports like

```
import range from 'lodash/range'
```

All of these imports are in test code (Lodash is a devDependency only),
so this won't affect the build. But it will make code style more
consistent, and it should slightly improve test performance.
@TrevorBurnham TrevorBurnham requested a review from a team as a code owner August 25, 2025 21:31
@TrevorBurnham TrevorBurnham requested review from pan-kot and removed request for a team August 25, 2025 21:31
import Axe from 'axe-core';
import { HtmlValidate } from 'html-validate';
import { compact, uniq } from 'lodash';
import compact from 'lodash/compact';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add an ESLint rule for pages to reinforce this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants