Skip to content

Conversation

@iancaffey
Copy link

… PropertyFilter token

Description

PropertyFilter uses an Autosuggest for typing in filter conditions, which allows users to type out entire labels of properties (e.g. "Instance ID"). And this is incredibly helpful for searching for substring matches within properties.

But since the token editor uses a Select for property, users have a limited ability to do similar searches when trying to locate the property they wish to change.

Users can type the prefix of the property they're interested in (i.e. standard native input features we're used to), but pressing the enter key ends up selecting the current option in the dropdown.

So for example, if I was trying to find the "Instance ID" property within the property dropdown when editing a token, if I started typing "Instance" and then pressed enter/space, it would select the first property that started with "Instance" instead of allowing me to continue typing out "Instance ID".

Related links, issue #, if available: n/a

AWSUI-60485

How has this been tested?

Added a new test cases which verifies client-side filtering works as expected. Also verified manually in property-filter-editor-permutations locally.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants