fix: Ensure toggle button test utils only find toggle buttons #3868

gethinwebster · 2025-09-16T08:54:35Z

Description

Re-run of #3816 with adjusted implementation for better cross-version compatibility

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

Changes include appropriate documentation updates.
Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
Changes do not include unsupported browser features, see CONTRIBUTING.md.
Changes were manually tested for accessibility, see accessibility guidelines.

Security

If the code handles URLs: all URLs are validated through the checkSafeUrl function.

Testing

Changes are covered with new/existing unit tests?
Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

codecov · 2025-09-16T09:35:29Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.15%. Comparing base (e5e2ffc) to head (0188b2c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3868      +/-   ##
==========================================
- Coverage   97.15%   97.15%   -0.01%     
==========================================
  Files         854      854              
  Lines       24960    24959       -1     
  Branches     8792     8794       +2     
==========================================
- Hits        24251    24250       -1     
  Misses        660      660              
  Partials       49       49

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

georgylobko · 2025-10-14T12:31:44Z

src/test-utils/dom/button/index.ts

 export default class ButtonWrapper extends ComponentWrapper<HTMLButtonElement> {
-  static rootSelector: string = styles.button;
+  static rootSelector: string = buttonTestUtilsStyles.root;
+  static legacyRootSelector: string = 'awsui_button_vjswe';


I would suggest writing a unit test for this scenario - just copy the HTML markup for the legacy selector and verify it still works correctly. Yes, this scenario is technically covered in this repository: https://github.com/cloudscape-design/test-utils/blob/c7200f200913812a551c8286bb4d1dccd5087565/src/core/test/selectors.test.ts#L116

The difference is that this selector skips the last hash part, which is why I still recommend doing it this way

good call, turns out what I had didn't actually work! updated

just-boris · 2025-10-14T12:47:59Z

src/test-utils/dom/toggle-button/index.ts

 export default class ToggleButtonWrapper extends ButtonWrapper {
-  static rootSelector: string = buttonStyles.button;
+  static rootSelector: string = testStyles.root;
+  static legacyRootSelector: string = '';


Is this empty selector needed?

yes, because extends ButtonWrapper

Understood. Great that you handle it, but also important learning to check all descendants when using this property on other wrappers

No more questions from me on this PR, removing myself

georgylobko · 2025-10-15T09:31:05Z

src/button/__integ__/button.test.ts

+
+describe('legacy selectors', () => {
+  test(
+    'finds legacy and new buttons',


[non-blocking] I'd suggest to turn this test and its page to a unit test since it's faster and less resource-intensive than running it in the browser

see below, unit and integ tests handle selectors a bit differently, so this is deliberate

georgylobko · 2025-10-15T09:38:50Z

src/test-utils/dom/button/index.ts

 export default class ButtonWrapper extends ComponentWrapper<HTMLButtonElement> {
-  static rootSelector: string = styles.button;
+  static rootSelector: string = buttonTestUtilsStyles.root;
+  static legacyRootSelector: string = 'awsui_button_vjswe_t8nlg_157';


[non-blocking just curious] doesn't the hash at the end get regenerated with every build? I checked both the cloudWatch and lambda consoles though, and it looks like they both use this selector for their buttons

Yes the last hash segment changes regularly. That's why I added the test as an integ test: the selectors utils trim these "full" class selectors and turn them into [class*=...] instead, so that they are insensitive to the 2nd part of the hash. dom utils use the class as-is, as typically the dom test utils aren't used in multi-version environments.

#3868)" This reverts commit ee7ac59.

#3868)" (#3938)

gethinwebster force-pushed the dev-v3-gethinw-toggle-test-utils branch 2 times, most recently from 797b0f5 to 6d2013e Compare September 16, 2025 09:26

gethinwebster deployed to dev-pages September 16, 2025 09:35 — with GitHub Actions View deployment

gethinwebster marked this pull request as ready for review September 16, 2025 09:46

gethinwebster requested a review from a team as a code owner September 16, 2025 09:46

gethinwebster requested review from georgylobko and removed request for a team September 16, 2025 09:46

georgylobko previously approved these changes Sep 16, 2025

View reviewed changes

gethinwebster dismissed georgylobko’s stale review via 2c8eec2 September 16, 2025 11:48

gethinwebster force-pushed the dev-v3-gethinw-toggle-test-utils branch from 6d2013e to 2c8eec2 Compare September 16, 2025 11:48

gethinwebster deployed to dev-pages September 16, 2025 11:58 — with GitHub Actions View deployment

gethinwebster force-pushed the dev-v3-gethinw-toggle-test-utils branch 2 times, most recently from b4c3b23 to 458622e Compare September 19, 2025 09:05

gethinwebster deployed to dev-pages September 19, 2025 09:14 — with GitHub Actions View deployment

avinashbot mentioned this pull request Oct 1, 2025

feat: Standalone Token #3804

Merged

gethinwebster deployed to dev-pages-react16 October 14, 2025 08:44 — with GitHub Actions View deployment

gethinwebster deployed to dev-pages-react18 October 14, 2025 08:44 — with GitHub Actions View deployment

gethinwebster requested a review from georgylobko October 14, 2025 11:19

gethinwebster enabled auto-merge October 14, 2025 12:18

georgylobko reviewed Oct 14, 2025

View reviewed changes

just-boris reviewed Oct 14, 2025

View reviewed changes

gethinwebster added 2 commits October 15, 2025 10:39

fix: Ensure toggle button test utils only find toggle buttons

a73d37f

Add more tests, fix legacyRootSelector

8a3f88b

gethinwebster force-pushed the dev-v3-gethinw-toggle-test-utils branch from 30ca4c9 to 8a3f88b Compare October 15, 2025 08:39

gethinwebster deployed to dev-pages-react16 October 15, 2025 08:49 — with GitHub Actions View deployment

gethinwebster deployed to dev-pages-react18 October 15, 2025 08:49 — with GitHub Actions View deployment

georgylobko reviewed Oct 15, 2025

View reviewed changes

georgylobko previously approved these changes Oct 15, 2025

View reviewed changes

Add heading

0188b2c

gethinwebster dismissed georgylobko’s stale review via 0188b2c October 15, 2025 11:14

gethinwebster deployed to dev-pages-react18 October 15, 2025 11:23 — with GitHub Actions View deployment

gethinwebster deployed to dev-pages-react16 October 15, 2025 11:23 — with GitHub Actions View deployment

georgylobko approved these changes Oct 15, 2025

View reviewed changes

gethinwebster added this pull request to the merge queue Oct 15, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2025

gethinwebster added this pull request to the merge queue Oct 15, 2025

Merged via the queue into main with commit ee7ac59 Oct 15, 2025
49 checks passed

gethinwebster deleted the dev-v3-gethinw-toggle-test-utils branch October 15, 2025 12:52

gethinwebster added a commit that referenced this pull request Oct 15, 2025

revert: "fix: Ensure toggle button test utils only find toggle buttons (

0d6aad4

#3868)" This reverts commit ee7ac59.

github-merge-queue bot pushed a commit that referenced this pull request Oct 15, 2025

revert: "fix: Ensure toggle button test utils only find toggle buttons (

627449b

#3868)" (#3938)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Ensure toggle button test utils only find toggle buttons #3868

fix: Ensure toggle button test utils only find toggle buttons #3868

Uh oh!

gethinwebster commented Sep 16, 2025 •

edited

Loading

Uh oh!

codecov bot commented Sep 16, 2025 •

edited

Loading

Uh oh!

georgylobko Oct 14, 2025

Uh oh!

gethinwebster Oct 15, 2025

Uh oh!

just-boris Oct 14, 2025

Uh oh!

gethinwebster Oct 14, 2025

Uh oh!

just-boris Oct 14, 2025

Uh oh!

georgylobko Oct 15, 2025

Uh oh!

gethinwebster Oct 15, 2025

Uh oh!

georgylobko Oct 15, 2025

Uh oh!

gethinwebster Oct 15, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: Ensure toggle button test utils only find toggle buttons #3868

fix: Ensure toggle button test utils only find toggle buttons #3868

Uh oh!

Conversation

gethinwebster commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How has this been tested?

Correctness

Security

Testing

Uh oh!

codecov bot commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gethinwebster commented Sep 16, 2025 •

edited

Loading

codecov bot commented Sep 16, 2025 •

edited

Loading