Skip to content

fix: vertical centering for h2 headers without description in expandable sections #3944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 27, 2025
Merged

fix: vertical centering for h2 headers without description in expandable sections #3944

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8eaae54
Update the spacing for header
Who-is-PS Oct 15, 2025
6553a7a
Update code for vertical alignment of header in expanable section
Who-is-PS Oct 17, 2025
b992083
vertical alignment is applied when the expandable section is closed a…
Who-is-PS Oct 24, 2025
374f544
removed some stlying
Who-is-PS Oct 24, 2025
18ed291
retrigger checks due to flakiness
Who-is-PS Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/expandable-section/expandable-section-header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,14 @@ const ExpandableHeaderTextWrapper = ({
{...(headerButtonListeners ? getExpandActionAnalyticsMetadataAttribute(expanded) : {})}
>
<span className={clsx(styles['icon-container'], styles[`icon-container-${variant}`])}>{icon}</span>
<span id={id} className={clsx(styles['header-text'], analyticsSelectors['header-label'])}>
<span
id={id}
className={clsx(
styles['header-text'],
analyticsSelectors['header-label'],
!expanded && !headerDescription && styles['not-expanded']
)}
>
{children}
</span>
</span>
Expand Down
26 changes: 14 additions & 12 deletions src/expandable-section/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,18 +138,18 @@ $icon-total-space-medium: calc(#{$icon-width-medium} + #{$icon-margin-left} + #{
// Equal top and bottom padding so standalone header has vertical symmetry.
padding-block-end: awsui.$space-container-header-top;
}
&.header-deprecated {
padding-inline-start: container.$header-padding-horizontal;
}
&:not(.header-deprecated) {
padding-inline-start: calc(#{container.$header-padding-horizontal} + #{$icon-total-space-medium});
}
}
&.header-deprecated {
padding-inline-start: container.$header-padding-horizontal;
}
&:not(.header-deprecated) {
padding-inline-start: calc(#{container.$header-padding-horizontal} + #{$icon-total-space-medium});
}

@include focus-visible.when-visible {
// HACK: Remediate focus border
padding-block: calc(#{awsui.$space-scaled-s} - #{awsui.$border-divider-section-width});
padding-inline: calc(#{awsui.$space-l} - #{awsui.$border-divider-section-width});
}
@include focus-visible.when-visible {
// HACK: Remediate focus border
padding-block: calc(#{awsui.$space-scaled-s} - #{awsui.$border-divider-section-width});
padding-inline: calc(#{awsui.$space-l} - #{awsui.$border-divider-section-width});
}
}

Expand Down Expand Up @@ -228,7 +228,9 @@ $icon-total-space-medium: calc(#{$icon-width-medium} + #{$icon-margin-left} + #{
}

&-text {
/* used in test-utils */
&.not-expanded {
padding-block: awsui.$space-xxs;
}
}
}

Expand Down
Loading