Skip to content

Conversation

@Harsh-Anand-Singh
Copy link
Member

Description

This PR adds a default aria-label for the DatePicker calendar button, fixing an accessibility issue where the button had no label when openCalendarAriaLabel was not provided.

Related links, issue #, if available: AWSUI-61446

How has this been tested?

Added unit tests to verify the calendar button has the correct default aria-label with and without a selected date.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Harsh-Anand-Singh Harsh-Anand-Singh marked this pull request as ready for review November 17, 2025 17:19
@Harsh-Anand-Singh Harsh-Anand-Singh requested a review from a team as a code owner November 17, 2025 17:19
@Harsh-Anand-Singh Harsh-Anand-Singh requested review from cansuaa and removed request for a team November 17, 2025 17:19
@Harsh-Anand-Singh Harsh-Anand-Singh marked this pull request as draft November 17, 2025 17:22
@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.99%. Comparing base (9edb184) to head (92df6e1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4043   +/-   ##
=======================================
  Coverage   96.99%   96.99%           
=======================================
  Files         861      861           
  Lines       25210    25212    +2     
  Branches     9097     9099    +2     
=======================================
+ Hits        24452    24454    +2     
+ Misses        752      711   -41     
- Partials        6       47   +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant