Retry mechanism for service account#63
Merged
Merged
Conversation
AnkitCLI
force-pushed
the
AddingRetryWithFailsafe
branch
7 times, most recently
from
April 30, 2025 09:33
d9e9f00 to
e5c089a
Compare
psainics
reviewed
May 5, 2025
| @@ -0,0 +1,48 @@ | |||
| /* | |||
| * Copyright © 2022 Cask Data, Inc. | |||
| return this; | ||
| } | ||
|
|
||
|
|
| * @param statusCode the HTTP status code (should be in the 5xx range) | ||
| * @param message the detail message explaining the error | ||
| */ | ||
| public ServerErrorException(int statusCode, String message) { |
Collaborator
There was a problem hiding this comment.
i think we can use the enum for statusCodes from http lib
Collaborator
Author
There was a problem hiding this comment.
done . In this way?
| CryptoKeyName cmekKeyName = CmekUtils.getCmekKey(config.cmekKey, context.getArguments().asMap(), collector); | ||
| collector.getOrThrowException(); | ||
| baseConfiguration = getBaseConfiguration(cmekKeyName); | ||
| baseConfiguration.set("initialRetryDuration", Integer.toString(config.getConnection().getInitialRetryDuration())); |
Collaborator
There was a problem hiding this comment.
move the keys to BigQueryConstants and follow a similar naming scheme
AnkitCLI
force-pushed
the
AddingRetryWithFailsafe
branch
3 times, most recently
from
May 5, 2025 09:44
2cf8920 to
0707493
Compare
AnkitCLI
force-pushed
the
AddingRetryWithFailsafe
branch
6 times, most recently
from
June 5, 2025 07:25
1011aff to
4bf53f8
Compare
AnkitCLI
force-pushed
the
AddingRetryWithFailsafe
branch
2 times, most recently
from
June 16, 2025 06:20
39dab19 to
2cd1c91
Compare
AnkitCLI
force-pushed
the
AddingRetryWithFailsafe
branch
from
July 8, 2025 05:44
dea8c9c to
acd0f0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.