fix(parser): stability issues#45
Merged
Merged
Conversation
When trying to `getSymbolByLocation(loc)`, multiple entity symbols could
contain `loc`. For example: `trait MyTrait { fn my_trait<<loc> }`, both
`MyTrait` and `my_trait` could be selected by `filterEntitySymbols`, but
the expected result is `my_trait` since it is more specific.
welkeyever
reviewed
Jul 8, 2025
welkeyever
reviewed
Jul 8, 2025
simuleite
pushed a commit
to simuleite/abcoder
that referenced
this pull request
Feb 28, 2026
* fix(collect): do not corrupt functionInfo
* fix(collect): fix duplicates in filterEntitySymbols
When trying to `getSymbolByLocation(loc)`, multiple entity symbols could
contain `loc`. For example: `trait MyTrait { fn my_trait<<loc> }`, both
`MyTrait` and `my_trait` could be selected by `filterEntitySymbols`, but
the expected result is `my_trait` since it is more specific.
* doc(collect): add docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
解决 issue #33 : parser 不稳定的问题（对于同样输入输出不同）
因为 issue #44 的存在，现有的两个 commit 只能解决没有 trait object 的情况。
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
#33
(optional) The PR that updates user documentation: