Address feedback 2 cassandra #9
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate config out into os/arch/toolchain specific files. Remove options that we inherit from omr already (eg -fno-strict-aliasing, -qalias=noansi) Signed-off-by: Devin Nakamura <[email protected]>
…ic_load_cassandra
- compile tests for JCL_VERSION=latest JDK_IMPL=ibm [ci skip] Signed-off-by: Renfei Wang <[email protected]>
Signed-off-by: Babneet Singh <[email protected]>
IBMJ9 has started to use JVM_*Signal functions in the sun.misc.Signal class. So, it is no longer dependent on shutDownHookWrapper. Hence, shutDownHookWrapper is removed. Signed-off-by: Babneet Singh <[email protected]>
The experimental value types support uses the letter Q before the class name for a value type class. This change handles the following cases: 1) In building a TR:TypeLayout in J9ClassEnv.cpp, treat a field that has Q before a class name as being of type TR::Address. 2) The code in TR_J9VM::getClassFromSignature strips off any leading 'L' and trailing semicolon from the signature string for a class that it is looking up. For value types, it also needs to strip off any leading 'Q'. 3) In jitParseSignature in ctsupport.cpp, allow for the letter Q before a class name in parsing signatures. Signed-off-by: Henry Zongaro <[email protected]>
For a defaultvalue bytecode, if the class is resolved, generate a newvalue instruction with default values for the fields as operands. Recursively generate a newvalue for any fields that are themselves value types. The JIT compiler is not yet able to handle the case of an unresolved class used in a defaultvalue bytecode instruction. Simply fail the compilation during ILGen if an unresolved class is encountered in that situation. The failure is reported as an UnsupportedValueTypeOperation exception. The intention is that these can be replaced with OSR points in the future. In order to track the frequency with which we are failing compilations due to encountering unresolved classes during IL generation for the defaultvalue bytecode, use static debug counters that begin with the string "ilgen.abort/unresolved/defaultvalue". Signed-off-by: Henry Zongaro <[email protected]>
Signed-off-by: Marius Pirvu <[email protected]>
Fix debug build break in JITServer code
This commit implements `TR_UnloadedClassPicSite::compensate` for aarch64. Signed-off-by: Akira Saitoh <[email protected]>
…ookWrapper Remove shutDownHookWrapper
The change is to obtain the actual utf8 string length after copy back from copyStringToUTF8WithMemAlloc() in verifyQualifiedName(). Signed-off-by: Cheng Jin <[email protected]>
AArch64: Implement TR_UnloadedClassPicSite::compensate
Signed-off-by: Peter Shipton <[email protected]>
CMake: Refactor platform specific config
IL Generation for defaultvalue bytecode instruction
Update OpenSSL to 1.1.1f
Enable ProxyFieldAccess tests for JCL_VERSION=latest
- Use flattened size when iterating flattened arrays - Use object ptr in Mixed and Reference scanner constructors - Add more value type array tests - Add tests for all assorted value alignment types - Make sure tests are validating after a GC Signed-off-by: Andrew Young <[email protected]>
…_qualified_name_check_openj9 Update the UTF8 string length in verifyQualifiedName
…icolon Remove unneeded semicolons, and minor formatting
…ic_load_cassandra
…er-2 Add FlattenedArrayObjectScanner
…ss_feedback_2_cassandra
Owner
|
Merged locally then pushed to #7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.