New edition of process_pr #2626
Draft
+15,238
−55,594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iarspider
force-pushed
the
sign-hashes-not-commits
branch
from
87a48fb to
f94d70c
Compare
Contributor
|
cms-bot internal usage |
Contributor
|
Pull request #2626 was updated. |
Contributor
|
Pull request #2626 was updated. |
Contributor
|
Pull request #2626 was updated. |
1 similar comment
Contributor
|
Pull request #2626 was updated. |
iarspider
force-pushed
the
sign-hashes-not-commits
branch
from
e539998 to
5fc68a2
Compare
Contributor
|
Pull request #2626 was updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@smuzaffar as discussed today. I have put new code into new file (
process_pr_v2.py), will replace oldprocess_prbefore merging.It doesn't yet do everything - for example, it won't detect when tests are complete, I will implement it later.
We can also use this opportunity to implement our own handling of commit statuses (I have a draft cgi handler for this) that we should discuss offline.