Reduce overtime in relay_render_to_plane#11901
Open
noelle-lavenza wants to merge 2 commits intocmss13-devs:masterfrom
Open
Reduce overtime in relay_render_to_plane#11901noelle-lavenza wants to merge 2 commits intocmss13-devs:masterfrom
noelle-lavenza wants to merge 2 commits intocmss13-devs:masterfrom
Conversation
cmss13-ci
bot
added
Refactor
Contributor
Test merge deployment history:Test Merge Deployed @ 03/08/2026 21:49:07 +00:00:Server InstanceRevisionTest Merge Updated @ 03/09/2026 00:45:51 +00:00:Server InstanceRevisionTest Merge Updated @ 03/09/2026 01:12:33 +00:00:Server InstanceCM13 Live RevisionOrigin: cb54193 Test Merge Updated @ 03/09/2026 02:43:29 +00:00:Server InstanceCM13 Live RevisionOrigin: 875069c Test Merge Updated @ 03/09/2026 08:45:18 +00:00:Server InstanceCM13 Live RevisionOrigin: d5dbcb1 Test Merge Updated @ 03/09/2026 10:08:59 +00:00:Server InstanceRevisionTest Merge Updated @ 03/09/2026 11:16:28 +00:00:Server InstanceCM13 Live RevisionOrigin: 63fcc66 Test Merge Updated @ 03/09/2026 11:45:57 +00:00:Server InstanceRevisionTest Merge Updated @ 03/09/2026 12:27:54 +00:00:Server InstanceRevision |
This was referenced Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the pull request
Instead of checking
in screeninrelay_render_to_plane, we check an alist that exists specifically for this purpose. This ensures we don't have to loop over the entirescreenlist searching for each relay. That saves a ton of overtime.We also don't recreate the planemaster's
relayif it already exists. This seems to have saved the rest of the overtime, because now it's extremely low per call.Explain why it's good for the game
Reduces overtime from 1.93568 per 292193 calls to a projected 0.2783 per 292193 calls (actual numbers are 0.002/2100, so it could be slightly better in practice due to rounding).
With a second change, I was able to get it even lower: for spamming F12 to call
show_hud()over and over again, it was 0.001/6755, which is 0.0433 overtime per call. When spammingaghostandRe-enter corpse, it actually had an overtime of 0 for 3465 calls, which is incredible. Everything looks fine as well!I would feel most comfortable if this was testmerged, but it seemed alright in local testing, at least.
Testing Photographs and Procedure
Runtime map looks fine, stairs aren't broken, openspace isn't broken, darkness/lighting isn't broken.
Screenshots & Videos
Changelog
🆑 MoondancerPony
refactor: refactored plane render relay plate code to reduce overtime lag from observing and changing mobs
/:cl: