Repository navigation
[guide] Gate proposal: pin CONTRIBUTING step-5 check descriptions to package.json reality #1923
Description
Class: CONTRIBUTING prose describes a gate and drifts when the script changes
This is the third instance of the same root cause — contributor-facing prose in CONTRIBUTING.md states what a check:*/validate:* script does, the script changes, and nothing fails:
- [guide] CONTRIBUTING.md still says no validate:end-user-talks script exists (added by #1624) #1663 — CONTRIBUTING claimed no
validate:end-user-talksscript existed after ci: validate end-user-talks.json links on the Netlify publish path #1624 added it. - [guide] Justfile shortcuts paragraph: 'superset of the Netlify build' is false — just build never runs validate:end-user-talks #1703 — the Justfile paragraph claimed
just buildwas a superset of the Netlify build when it was not (remediated with the scoped contracttests/contributing-just-build-parity.test.mjs). - This week — the step-5 bullet described
check:linksasmarkdown-link-checkover Markdown only, after feat: check the outbound URLs the site renders from data/ #1904 made it_check:links-md && _check:links-data. Fixed as a one-off in docs: describe the data-URL half of check:links in CONTRIBUTING #1922.
The repository's established remediation for this class is a section-scoped parity contract: tests/contributing-just-build-parity.test.mjs pins the Justfile section, tests/contributing-e2e-setup.test.mjs pins the e2e setup section, tests/docs-threshold-parity.test.mjs pins the coverage thresholds. Nothing pins the step-5 npm run check member bullets (check:audit, check:links, check:community-group-links) — the prose that tells a contributor what each extra check in the aggregate does — against package.json and the scripts those names resolve to.
Proposal
Add one contract test in the existing contributing-*-parity style that asserts, for each check:* script named in CONTRIBUTING.md step 5, that the script exists in package.json and that the prose's load-bearing claims (network dependence, GH_TOKEN requirement, files it rewrites, the data-URL half of check:links) match the resolved script chain. A weakened-input fixture per claim, per the standard tests/e2e-coverage-gate.test.mjs sets.
What to reply
Accept and this can be implemented as a follow-up; decline and individual findings in this class resume being filed one at a time.
Risk: governance
Filed by guide agent (ACMM L5 — hold-gated mode)
🐝 Hive Agent: guide | Instance: hosted-available-lke648397-260827-5n31 | SHA: f91ce45
— hive: agent=guide backend=copilot model=kimi-k3 copilot=1.0.88
Activity
hivecommons-hive commentedon Oct 25, 2026
What to reply
/hive approve: go with the recommendation/hive decision <your instructions>: go ahead, following your instructions/hive help: show these againIf what this issue waited on has been done (a merged fix, or an action taken outside this repository), a maintainer can reply
/fixedto close it as completed; Hive clears its park labels.Only a maintainer with write access can un-park; everything else is ignored. Full command reference: https://github.com/hivecommons/hive/blob/v5/src/docs/maintainer-commands.md.
mrbobbytables commentedon Oct 26, 2026
/hive decision Decline.
The current instance was already fixed in #1922, and nothing an end user can observe depends on the step-5 prose. A contract test pinning CONTRIBUTING bullets to the
package.jsonscript chain is a guard over the contributor docs, which ADR 0006 and ADR 0008 place outside agent remit unless a maintainer files it. When the prose drifts again, fix the sentence; do not build a harness for it. This decision binds later findings in this class (ADR 0008): comment here rather than re-filing.Closing as not planned.