Repository navigation
test(e2e): retire a11y baseline entries from the per-route scans - #1908
Merged
Merged
Conversation
accessibility.spec.js proved its baseline still failed by rescanning every baselined route, state and content page serially in three extra tests, about 25s of the suite's wall time and its slowest single test. Every one of those routes is already scanned by its own per-route test, so check both halves of the contract there: nothing unrecorded may be reported, and every recorded rule must still be reported in light mode, the mode the serial rescans ran in. A stale entry still fails the file with the same delete-it message; it now costs no extra navigation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
✅ Deploy Preview for endusers ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remit: required CI check latency.
accessibility.spec.jsrescanned every baselined route, state and content page serially in three retirement tests (~25s wall; the 20s route rescan was the slowest single test in the suite).What changes
expectBaselined()helper asserts both halves of the baseline contract against each per-route scan's results: nothing unrecorded is reported, and every recorded rule is still reported (in light mode, matching the mode the serial rescans used).Verification
E2E_COVERAGE=1 --workers=2): 102 passed.NAVBAR_VIOLATIONSfails the light-mode home scan with/: these rules no longer fail — delete them from KNOWN_VIOLATIONSand leaves dark mode passing, as intended.npm run test:unit, prettier, eslint, spelling, duplication pass locally.