Skip to content

test(e2e): drop the coverage lane's two-worker cap - #1912

Closed
mrbobbytables wants to merge 1 commit into
mainfrom
ci/coverage-workers
Closed

mrbobbytables wants to merge 1 commit into
mainfrom
ci/coverage-workers

Conversation

@mrbobbytables

Copy link
Copy Markdown
Member

Remit: required CI check latency. "End-to-end coverage" is now the longest required check (~6 min, 210s of it the Playwright run at --workers=2).

What changes

Verification

  • Experiment: compare this PR's "Run e2e tests with coverage" step against the 210s baseline and confirm the coverage report still renders and passes its gate. Close without merging if not faster or if artifacts conflict.

The coverage lane has passed --workers=2 since it was added as a
non-gating measurement; nothing recorded why. The gating lane runs
four workers against the same single docusaurus serve process, so let
the coverage lane use the config's four as well.

Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@netlify

netlify Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for endusers ready!

Name Link
🔨 Latest commit 42f92aa
🔍 Latest deploy log https://app.netlify.com/projects/endusers/deploys/6ade6009710f03e50cfd7865
😎 Deploy Preview https://deploy-preview-1912--endusers.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hivecommons-hive

Copy link
Copy Markdown
Contributor
42f92aa

ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blocked

Hive flagged this PR (author @mrbobbytables, head 42f92aa1422c) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • sensitive_path — changes 1 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • package.json

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@mrbobbytables

Copy link
Copy Markdown
Member Author

Measured: "Run e2e tests with coverage" took 152s with 4 workers (this PR) and 152s with 2 workers (#1913, same day, same runner class). The coverage lane is CPU-bound on V8 coverage collection rather than on page I/O, so the extra workers buy nothing. Closing without merging, as the description said; the --workers=2 cap stays.

@mrbobbytables
mrbobbytables deleted the ci/coverage-workers branch October 25, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant