Skip to content

fix(dynamic-agents): pin validated fetch addresses - #2367

Draft
sriaradhyula wants to merge 2 commits into
mainfrom
prebuild/fix/fetch-url-dns-pinning
Draft

fix(dynamic-agents): pin validated fetch addresses#2367
sriaradhyula wants to merge 2 commits into
mainfrom
prebuild/fix/fetch-url-dns-pinning

Conversation

@sriaradhyula

@sriaradhyula sriaradhyula commented Aug 11, 2026

Copy link
Copy Markdown
Member

Description

Keep fetch connections aligned with the address approved during URL validation.

  • Resolve and validate all addresses once per request hop.
  • Connect to the selected validated address.
  • Preserve the original Host header, TLS server name, and certificate hostname check.
  • Disable environment-proxy inheritance for these direct requests.
  • Re-resolve, revalidate, and repin each redirect hop.

Type of Change

  • Bugfix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Pre-release Helm Charts (Optional)

No chart changes.

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests

Validation

  • 18 focused tests passed, including a real pinned local socket request
  • Redirect repinning, Host preservation, IPv6 formatting, and no-fallback behavior covered
  • Ruff passed

Signed-off-by: Sri Aradhyula <sraradhy@cisco.com>
@github-actions

Copy link
Copy Markdown
Contributor

✅ No proprietary content detected. This PR is clear for review!

@github-actions github-actions Bot added the dev Normal PR to main; uses dev prerelease versioning label Aug 11, 2026
Signed-off-by: Sri Aradhyula <sraradhy@cisco.com>
@github-actions

Copy link
Copy Markdown
Contributor

ℹ️ Branch is behind main (advisory, non-blocking)

Commit: 8118ccc1

This branch does not yet contain the latest main. This does not fail the version-bump check — version files are bumped once the branch is updated, and GitHub branch protection still requires the branch to be up to date before merge. Use the Update branch button on this PR, or run:

git fetch origin main
git checkout prebuild/fix/fetch-url-dns-pinning
git merge FETCH_HEAD
git push

This is a prebuild/* branch, so Helm prebuild publishing will still run so you can test the chart changes while the branch is being updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dev Normal PR to main; uses dev prerelease versioning

Projects

Development

Successfully merging this pull request may close these issues.

2 participants